Commit Graph

150 Commits (2380d518081c7e003b8737bfd18af40d414ef8ee)

Author SHA1 Message Date
Jeff Boek ef6913ec25 For #5905 - Combine theme and toolbar settings 4 years ago
Gabriel Luong 64a4a7f422
Provide add-on support (#8064)
Closes #5630, #6069, #6092, #6091, #6124, and #6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
Sören Hentzschel 8a7c7fd06f For #7730 - always show "Add private browsing shortcut" in sett… (#7943) 4 years ago
ekager 053e5b8065 For #6396 For #6553 - Update sync engine checkboxes and send telemetry once 4 years ago
Jeff Boek 6789df55a5 For #220 - Puts language picker behind a feature flag 4 years ago
Mihai Branescu ea2411a88b Feature/#220 language menu (#7070)
* For #220
- Added advanced header + locale settings item in the settings fragment

* For #220
- Added locale selection page with lib state + handling of locale changes

* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For #220
- Added unit tests for locale settings page

* For #220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
4 years ago
Tiger Oakes b85673acac Clean up settings fragments 5 years ago
mcarare d2abac78eb For #7075 Update passwords preference visibility and string
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
5 years ago
ekager d8babadf7f For #6889 - Check current destination before navigating from settings 5 years ago
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
5 years ago
Tiger Oakes 422faaf7c0 Add toolbar helpers (#6531) 5 years ago
Denys M 6290c0c826 Closes #2441. Update LeakCanary to `2.0-beta-3` version. 5 years ago
ekager f49331de55 For #5544: Bare Minimum Logins UI 5 years ago
bswe 052695ffa1 Issue #5233: Minor modifications suggested in code review. 5 years ago
bswe 9913a024d8 Issue #5233: Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "add private browing shortcut" item is visible in the settings menu. 5 years ago
MozLando 8cf54f773b Merge #5882
5882: For #5873 Added on/off indicator for delete browsing data on exit pref r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
5 years ago
Sawyer Blatz b0d796ccee
For #5898: Default browser toggle sends user to SUMO on Android 5&6 (#5918) 5 years ago
mcarare 788e52be0c For #5873 Added on/off indicator for delete browsing data on exit pref 5 years ago
mcarare 22eb207cef For #5784: Fix hiding default browser preference in sdk<=23 5 years ago
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
5 years ago
Sawyer Blatz 2896b36d14
No issue: Updates naming of launch links privately var (#5701)
The previous name was pretty confusing
5 years ago
Sawyer Blatz eb3c9f86e2
No issue: Removes feature flags for delete data (#5738) 5 years ago
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
5 years ago
Emily Kager 9d9ff959b5 For #5312 - Add Telemetry for Tracking Protection 5 years ago
Tiger Oakes 6c30a94081 Move settings classes to packages 5 years ago
Sawyer Blatz 6f3d7b4ee8 For #5396: Adds "always launch in private mode" to settings 5 years ago
Sawyer Blatz 50cd2920d3
For #5371: Updates search engine settings string (#5393) 5 years ago
Emily Kager e3209dcc84 For #3700 - Add Setting to Delete Data on "Quit" menu action 5 years ago
Yeon Taek Jeong ddc1b2e648 For #4658: Add private browsing mode shortcut telemetry 5 years ago
Yeon Taek Jeong 2e2bac4ccd
For #419: Create launch icon for private browsing (#4948) 5 years ago
Tiger Oakes b77c4d2e2e Clean up SupportUtils 5 years ago
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 5 years ago
Grisha Kruglov 231924f5eb Fix breaking services APIs changes 5 years ago
Tiger Oakes aab357845b No issue: Clean up preferences code (#4699) 5 years ago
Jonathan Almeida ec96d134ff No issue: Fix breaking AccountObserver API 5 years ago
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 5 years ago
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 5 years ago
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 5 years ago
afr30010 c92eabdd64 Modify the order of Privacy Policy and About in Settings (#2760) 5 years ago
Tiger Oakes 30930cdc88 Import variables referred to by path 5 years ago
Tiger Oakes 55f5c5d049 Use lifecycleScope for settings fragments 5 years ago
Jeff Boek 7ebdfcc87b For #1116 - Uses alias link for help 5 years ago
Jeff Boek 5540230e3d For #1116 - Changes help link (#3491) 5 years ago
Jeff Boek 227a80957e For #382 - Include Marshmellow in the guard.. 5 years ago
Jeff Boek dad671ca3c For #382 - Hides default browser switch for older versions of Android 5 years ago
Grisha Kruglov fe3c163a20 Fix how we reflect FxA state in preference
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.

This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
5 years ago
Sawyer Blatz c4c5d44430 For #975: Updates telemetry for settings (#3171) 5 years ago
Sawyer Blatz 5e0771a6f0 For #2327: Fix early return from displayAccountError 5 years ago
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 5 years ago
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 5 years ago
Arturo Mejia b2e27d26dc Closes #2903: Fixed crash when trying to rate the app on a devices without
the play store app.
5 years ago
Sawyer Blatz 9aa4f48e77 For #1190: Adds additional telemetry for FxA login 5 years ago
Sawyer Blatz 62bed0cd06 For #1190: Adds telemetry for FxA login 5 years ago
Jeff Boek 182bbdf359 For #225 - Adds delete browsing data fragment 5 years ago
Sawyer Blatz 36f4b97712 For #658: Adds your rights page link 5 years ago
Emily Kager 7951a5f5df No issue: Update Account UI and visibility in onCreate so it doesn't flash (#2804) 5 years ago
Denys M 6b8938e47e Fixes #2739. Update sign-in preference visibility when screen is resumed. 5 years ago
Jeff Boek 16b3309053 For #2531 - Adds privacy notice to settings 5 years ago
Emily Kager c2339e9669 Closes #2699 - Removes Feedback from Settings 5 years ago
ekager 42d1491976 Closes #2635 - Save settings changes to new Shared Preferences file 5 years ago
Vlad Filippov 66a0cd5f9c Add FxA Pairing feature to "Turn On Sync" 5 years ago
Jeff Boek 27d8c09def
Fixes #1735 - adds the ability to write code against the build channel (#2388) 5 years ago
vladikoff e067ffbbf6 Initial view for the "Turn on Sync" fragment
UX: https://mozilla.invisionapp.com/share/QSR2F8UD4PN#/screens/357470308
5 years ago
Emily Kager a3cd92092a Closes #2168 Closes #2170 - Catch ClassCastException for non bool prefs 5 years ago
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 5 years ago
Sawyer Blatz 8928822e99
For #975: Adds telemetry for settings toggles (#1896)
* For #975: Adds telemetry for settings toggles

* For #975: Uses failable constructor
5 years ago
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 5 years ago
Emily Kager 4da5a26536 Closes #2000 - Don't flash LeakCanary setting in release builds (#2006) 5 years ago
Emily Kager 534d88f629 Closes #1894 - Fixes Help Page Navigation 5 years ago
Mitchell Hentges 92b6d4a925 Moves release flavour to build type (#1693) 5 years ago
Sawyer Blatz 23edd2559d
For #933: Adds caching of sign in state (#1647) 5 years ago
Emily Kager 01a181975d For #1084 - Add tracking protection toggle to quick settings dialog 5 years ago
Emily Kager 068744eb96 For #1084 - Add Setting to enable/disable TP 5 years ago
Emily Kager d7272d29de For #1408 - Set Toolbar titles in code (vs in navgraph) 5 years ago
Emily Kager a2200b6335 For #208 - Dark/Night Theme 5 years ago
Jeff Boek 379875a62a Fixes #1162 - replaces about page with an Android Fragment 5 years ago
Jeff Boek 756634bc6c For #1181 - Use appName in string locations 5 years ago
Colin Lee df40ec970e Simplify ItsNotBrokenSnack() and make resilient
Co-authored by: Emily Kager <ekager@mozilla.com>
5 years ago
Emily Kager 4963f7ccdb Add Snackbar to link testers to Github issue for features 5 years ago
ekager 80f386c411 Closes #120 - Add Preference for Remote Debugging
Co-authored-by: Emily Kager <ekager@mozilla.com>
5 years ago
Emily Kager 202b195215 Closes #1089 - Default Search Engine should be shown in Pref summary 5 years ago
Emily Kager 4f6cc8efec No issue: update Androidx dependencies 5 years ago
Sawyer Blatz 78c3db1fc8
Fixes #992: Updates account implementation for a-c 47.0 (#995) 5 years ago
Emily Kager 3a558f6f78 Closes #900 - Use Settings BrowserDirection from Settings 5 years ago
ekager 205af4153d Closes #867 - Update Default Browser Toggle in onResume 5 years ago
Emily Kager d15e4bb3fa Closes #877 - Add Search Engine Settings 5 years ago
Sawyer Blatz a79134fdc3
Closes #823 & Closes #835: Refactors openToBrowserAndLoad to include fromFragment (#833) 5 years ago
Christian Sadilek 1b1a9e0d11 Issue #418: Add account settings page and sign out functionality 5 years ago
Grisha Kruglov 46789f4c62 Issue #418: Basic Firefox Accounts integration
This patch integrates relevant a-c components, and updates the current Preferences
UI to allow signing-in and displaying basic account information (email, displayName).

Currently there's no Accounts UI, and so singing out or otherwise interacting with the
account isn't possible.
5 years ago
Sawyer Blatz 56dadad35a
Closes #292: Adds placeholder advanced settings fragments (#638) 5 years ago
Emily Kager 5b8d40e6e0 Closes #655 - Show/Hide toolbar in onResume 5 years ago
Colin Lee 3ccce1b4d2 Fixes #293: Adds about settings page
Co-authored-by: Sawyer Blatz <sblatz@mozilla.com>
5 years ago
Sawyer Blatz 53f391de60
Closes #537: Refactors private sessions (#629) 5 years ago
Sawyer Blatz e5fe80f928
Closes #347: Adds private browsing logic (#506)
* For #347: Adds private browsing logic

*  For #347: Adds private session explainer

* Adds persistence
5 years ago
Colin Lee 2bc769190e Fixes #401: Resolve known leak and install LeakCanary 5 years ago
Emily Kager 931778acac Add new tab and navigate to it 5 years ago
Emily Kager 0c8b2a8a1e Closes #449 - Adds Basic About Page with Dated Version Name 5 years ago
Emily Kager 77883c0f30 Closes #403 Use Fragments for Navigation, Add Toolbar to HomeActivity 5 years ago
Emily Kager 3c48b3eeca Style settings theme, add about category 5 years ago
Emily Kager 8368f4fbb2 Part of #288 - Set up basic settings menu 5 years ago