We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
This is not visible in production, but only debug. It shows three variables
being used to change the settings screen (title, icon and title-punctuation).
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.
Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
For issue #18132 update to proton icons first batch
(cherry picked from commit 21cf0b31a4)
For issue #19290 update to proton icons second batch
(cherry picked from commit 9bfb31519a)
For issue AC#10231 update proton icons third batch
(cherry picked from commit bf42a1786e)
Remove feature flag for proton icons re-design #18132
(cherry picked from commit 52587753a5)
For #19357: Remove bookmarks experiment and keep star-with-line icon.
(cherry picked from commit 93c6403882)
The main cause for this is that the `LifecycleProvider` needs to be set
to `State.RESUMED` to avoid the account manager's internal
`ObserverRegistry` from putting the UI observers into the paused state.
The rest of the changes is to rely the internal (safe) logic to
correctly sync and then update the tabs list.
* Add preferences for enable/disable sync for cc and addresses
* Set pref visibility based on feature flags
* Helper function for pin warning preferences and set default values for cc and addresses to false.
* Kdocs for relevant sync functions in account settings
* Default visibility to false for credit cards and addresses in account settings
Adam Novak
Roger Yang
Arturo Mejia
Christian Sadilek
James Hugman
Gabriel Luong
Jonathan Almeida
Mihai Adrian Carare
Grisha Kruglov
Elise Richards
Mugurell
Ionut Cristian Bedregeanu
Sebastian Kaspari
Codrut Topliceanu
mcarare
codrut.topliceanu