Commit Graph

17 Commits (1ec4cf8dad862661d599d4d6f3a32cb0e9d04735)

Author SHA1 Message Date
Gabriel Luong 1ec4cf8dad [fenix] For https://github.com/mozilla-mobile/fenix/issues/27667 - Remove import-ordering from the list of disabled ktlint rules 2 years ago
mcarare 932823c871 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26844: Fix ktlint issues and remove them from baseline. 2 years ago
Mugurell c6bb6c247e [fenix] For https://github.com/mozilla-mobile/fenix/issues/23876 - Update kotlinx-coroutines to 1.6.1. Refactor runBlocking in tests.
After the update `TestCoroutineDispatcher`, `TestCoroutineScope` and
`runBlockingTest` are deprecated.
Instead of these new `TestDispatcher`, `TestScope` and `runTest` APIs are used.

Took the oportunity to also replace most of the `runBlocking` calls with the
new `runTest` specially designed for running coroutines in tests API.
2 years ago
tristan-jea 34afc2a3f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23813 - Clear error message for nameOnCardLayout when valid name is submitted 2 years ago
Gabriel Luong 130fd3ec5f [fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename destructive attribute to textWarning 2 years ago
Gabriel Luong 948e9c4e85 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23771 - Set correct destructive text color for card editor error messages (https://github.com/mozilla-mobile/fenix/pull/23803)
Co-authored-by: tristan-jea <>
Co-authored-by: Tristan <99796140+tristan-jea@users.noreply.github.com>
2 years ago
Grisha Kruglov 6b7cdce783 [fenix] Fix breaking change in KeyProvider
`key` was renamed to `getOrGenerateKey` and is now a `suspend`.
2 years ago
mcarare e3b9c8b633 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917: Use View binding in settings screens. 3 years ago
Gabriel Luong 016379fbca [fenix] For https://github.com/mozilla-mobile/fenix/issues/19495 - Add validation for the name on card (https://github.com/mozilla-mobile/fenix/pull/19836)
- We want to ensure that name on card in the credit card is not empty when submitted. Display an appropriate error when the field is invalid.
3 years ago
Gabriel Luong d67678c9c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19492 - Provide the correct CreditCardNumber type to UpdatableCreditCardFields when updating a credit card (https://github.com/mozilla-mobile/fenix/pull/19692)
We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
3 years ago
Gabriel Luong d46ed809a6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/19680 - Show the card number when editing a credit card (https://github.com/mozilla-mobile/fenix/pull/19681) 3 years ago
Gabriel Luong a61586886b [fenix] For https://github.com/mozilla-mobile/fenix/issues/18271 - [Saved cards] Display the credit card provider icon and report the correct card type (https://github.com/mozilla-mobile/fenix/pull/19652) 3 years ago
mcarare 3681f15501 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18266: Validate credit card entry info. 3 years ago
Grisha Kruglov 632ba92ad5 [fenix] Fix breaking changes introduced by credit card encryption APIs 3 years ago
Gabriel Luong fd0b41c798 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18274 - [Edit card] Update a saved credit card information (https://github.com/mozilla-mobile/fenix/pull/19032) 3 years ago
Gabriel Luong baea2cdf4d [fenix] For https://github.com/mozilla-mobile/fenix/issues/18273 - [Edit card] Delete a saved credit card (https://github.com/mozilla-mobile/fenix/pull/19029) 3 years ago
Gabriel Luong ac29b50dfa [fenix] For https://github.com/mozilla-mobile/fenix/issues/18272 - [Edit card] Display a saved card information in the Edit card screen (https://github.com/mozilla-mobile/fenix/pull/18884) 3 years ago