Commit Graph

17 Commits (1ec4cf8dad862661d599d4d6f3a32cb0e9d04735)

Author SHA1 Message Date
Gabriel Luong 1ec4cf8dad [fenix] For https://github.com/mozilla-mobile/fenix/issues/27667 - Remove import-ordering from the list of disabled ktlint rules 2 years ago
Roger Yang c61875b081 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11404 - Add 'Open all' options in bookmarks
* Add "Open all in new tabs" options in bookmarks
* Add "Open all in private tabs" options in bookmarks
* Add metrics tracking if the usage of "Open all in..." in bookmarks

Co-authored-by: Pg <pg.developper.fr@gmail.com>
2 years ago
Roger Yang d2f30aebe8 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/11404 - Create open all function"
This reverts commit ea926e80173a310687f81df757c8b011aca84c5e.
2 years ago
Roger Yang b78bfb94cb [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/11404 - Add 'Open all in private tabs' option as requested."
This reverts commit 83ed1abdc0846e726e2fcb46d0fcb7539f1ff9c3.
2 years ago
Pg ef15f5154c [fenix] For https://github.com/mozilla-mobile/fenix/issues/11404 - Add 'Open all in private tabs' option as requested.
https://github.com/mozilla-mobile/fenix/pull/21212#discussion_r739172674

- Add option is tree dot menu
- Edit folder opening to be aware of browsing mode
- Add metrics
- Add unit tests for 'Open all in private tabs'
- Add Android tests for open all in private.
2 years ago
Pg 871604943d [fenix] For https://github.com/mozilla-mobile/fenix/issues/11404 - Create open all function
- Create element to be displayed

- Update the interface and bind in the view holder
Set the filter to limit this action to FOLDER.

- Create core function
Main logic is done on the controller (has it should be done). The whole
process is done in one coroutine to be non-blocking as many
(sub)folders & links can be present. If folder is empty, a toast is
displayed. Else iterate on items. When item is:
- a FOLDER -> restart process (without toast) on the folder
- a ITEM -> open it
- a SEPARATOR -> do nothing
Once finished, show the tabs tray.

Toast message is defined in fragment to have access to context.

- Create androidTest for openAllInTabs
- Create tests for handleBookmarkFolderOpening
- Display 'open all' options only if folder has at least on child:
A coroutine and suspended functions have to be used, since `getTree`
is async.
2 years ago
mcarare 932823c871 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26844: Fix ktlint issues and remove them from baseline. 2 years ago
TasosB 7c78a27e27 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21483 - Remove light theme tinting of folder icon in the Bookmark view 2 years ago
Sijan Rijal 17fc28304a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (https://github.com/mozilla-mobile/fenix/pull/15649)
For https://github.com/mozilla-mobile/fenix/issues/15497: Remove and disable the three dot menu button
4 years ago
Tiger Oakes d29e90717c [fenix] Merge bookmark item and folder view holders 4 years ago
Tiger Oakes 0e2cdbb0e0 [fenix] FNX-14513 ⁃ For https://github.com/mozilla-mobile/fenix/issues/12862: Use concept-menu in library (https://github.com/mozilla-mobile/fenix/pull/13332) 4 years ago
Kainalu Hagiwara cbdee5da2c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13156, https://github.com/mozilla-mobile/fenix/issues/13280 - Use payloads to bind bookmark viewholders.
Change the DiffUtil callback for bookmarks to use the generated equals()
method instead of only checking the title and url fields. This prevents
the BookmarkNode in our state from getting out of sync with the
BookmarkNode the viewholder is bound to.
4 years ago
ankur 0ff90accee [fenix] For https://github.com/mozilla-mobile/fenix/pull/13301, https://github.com/mozilla-mobile/fenix/issues/13038: hide overflow menu for all bookmark items in selected mode 4 years ago
Kainalu Hagiwara 3320f82bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12551 - Implement swipe to delete for bookmarks. 4 years ago
Mugurell 43e4bcc0b1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4396 - Add a Bookmarks Controller (https://github.com/mozilla-mobile/fenix/pull/4593)
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For https://github.com/mozilla-mobile/fenix/issues/4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For https://github.com/mozilla-mobile/fenix/issues/4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
5 years ago
Tiger Oakes 9daf0c9542 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/2379 - Generic library selection 5 years ago
Tiger Oakes d4200df79c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2379 - Use LibrarySiteItemView in history 5 years ago