This patch adds:
* `translations_action` probe
* Extras:
* main_flow_toolbar - Interaction with toolbar button
* main_flow_browser - Interaction with browser menu button
* page_settings - Interaction with page settings
* global_settings - Interaction with global settings
* global_lang_settings - Interaction with language settings
* global_site_settings - Interaction with site settings
* downloads - Interaction with downloads
The goal of this bug is to get a very basic initial `translate`
interaction using the default determined page language and default
determined user language and begin starting `Controller` and `Interactor`
files.
This bug also sets up `sessionId` as a navigation parameter for
translations.
Rather than tracking that the CFR was shown to the user when the
user explicitly interacts with it (dismiss or action tap),
we will track it when the CFR was shown, not considering how the
user dismissed it.
Using `.inc()` was wrong due to it returning the incremented
value and not incrementing the already existing one. This
patch aims to fix that, therefore showing the CFR correctly
for max 3 times.
The current onboarding CFR is set to show the first time someone
lands on a product detail page. If the user dismisses the CFR and
does not opt-in, we show it on the next product detail page after at
least 24 hours have elapsed.
This patch changes this to showing the CFR up to 3X (instead of 2)
with at least 12 hrs in-between (instead of 24).
These are mostly mechanical changes to replace usage of `testHasValue`
with `testGetValue`.
`testGetValue` will now return `null` instead of throwing an exception
if no data is available.
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
* Navigate to home on toolbar click. Handle back press from search dialog
Update tests to show home behind search dialog. Remove unused test.
Jump back in show all button is clickable behind search dialog
Recently saved bookmarks show all button is clickable behind search dialog
* Add feature flag
* Past explorations show all button is clickable behind search dialog
Handle keyboard in controllers instead of viewholders. Update tests.
Allow collections to be visible behind search dialog
Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard
Verify navigateUp in tests
Adding ignore for flaky UI test
Only resize home behind search dialog
Add ignore for collection intermittent test
Cleanup
Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.
We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
ohall-m
Matthew Tighe
DreVla
Jeff Boek
Gabriel Luong
Alexandru2909
mcarare
Jan-Erik Rediger
Alexandru2909
Christian Sadilek
Grisha Kruglov
Elise Richards
Sebastian Kaspari
ekager
Mugurell
Tiger Oakes
Kainalu Hagiwara
ekager
Mihai Branescu
David Walsh