15 Commits (03c4a159d4e54ae11946da37ec7b192bfe51fb59)

Author	SHA1	Message	Date
MarcLeclair	990bfa7e6d	16900 make navgraph inflation asynchronous (#18889) ... * For #16900: implement async navgraph inflation For #16900: removed nav graph from xml For #16900: inflate navGraph programatically For #16900: Made NavGraph inflation asynchronous For #16900: Changed to block with runBlocking For #16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For #16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For #16900: inflateNavGraphAsync now takes navController For #16900: Pass lifecycleScope to NavGraphProvider For #16900: removed unused mock For #16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For #16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For #16900: Cleaned duplicated code in tests For #16900: cleaned up NavGraphTestRule for finished test For #16900: had to revert an accidentally edited file For #16900: rebased master * For #16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For #16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>	3 years ago
Kershan	02d70d3837	For #18453 - Show SUMO for default browser deeplink on Android <N ... Lower Android versions don't offer the possibility of opening system settings at a specific preference. In this cases we already shown a sumo article detailing the manual steps each user is expected to perform to change the system set default browser.	3 years ago
yichiehc	dd09ba64c4	For #18594: Highlight the "Default browser" system setting on Android >= N ... Although not public APIs we can use specific extras in the Intent used to open system settings such that the "Default browser" setting is highlighted to provide a better UX for users looking to set Fenix as default.	3 years ago
Sebastian Kaspari	77263aad70	Validate deep links.	4 years ago
James Hugman	798c1bf743	Address review comments	4 years ago
James Hugman	22689a9ff5	Remove need to specify component names for new intents	4 years ago
James Hugman	98a33ea82b	Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is	4 years ago
James Hugman	1629878a66	Add install_search_widget	4 years ago
James Hugman	8130aaa2cc	Add deep links for settings and home screens	4 years ago
Jonathan Almeida	ffd4cdd970	For #7661: Add variant-specific schemas for deep links ... In order to target specific variants of Fenix, we're adding schemas that are specific that app in order to avoid collisions with the other variants and with other forks of fenix that may have the same schemas. The current schema for variants: - Fenix Nightly: `fenix-nightly://` - Fenix Beta: `fenix-beta://` - Everything else: `fenix://`	4 years ago
Arturo Mejia	ce4293c8c8	For issue #8908 Notify users when previously unsupported add-ons ... become available	4 years ago
Jeff Boek	541bcf072a	Reverts all BrowsingModeManager changes	4 years ago
Simon Chae	2c01022c4b	For #8153: Allow web-ext to open new tabs in correct browsing mode	4 years ago
Emily Kager	b9f6f7fa93	For #4779 : Don't double navigate with global directions in HomeActivity	5 years ago
Tiger Oakes	9f154dc3a0	Extract intent processors from HomeActivity (#4884)	5 years ago