3 Commits (023a4983fa769a6fb9eea6600ec7ce8e620618c4)

Author	SHA1	Message	Date
Elise Richards	023a4983fa	For #10173: login duplicates and save (#11208) ... * Extract controller into it's own class. Implement find dupes and filter based on username. Create edit login controller. Add text watchers and check for duplicates. Edit controller test * Find duplicates and save to store * Retrieve duplicates from AC and check list on username text changed Move duplicates logic into the controller * Add glean pings for delete and edit. Move logic for login manipulation into the datastore. * Use correct threads in controller. Enable save button when applicable. Save enabled in datastore. Move login data to datastore Rebase with password error states Update metrics to be more specific for edit * Create logins controller for AC calls * Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation. Inflate view in edit fragment. Double layout showing up. Edit view Controller tests Controller tests passing Interactor tests Lint and detekt cleanup * Remove datastore and use storage controller for all logins calls to password storage. Addressed comments Lint : Rebase - 1	4 years ago
Mugurell	e1fc0cc038	Ensure logins deletion (#12507) ... * For #11227 - Cleanup saved logins list when one is selected Selecting a saved login will open a detail screen for it from where users can change details or even delete that particular login. After the change is made the user is brought back to the list of saved logins where for a brief moment (< 1s) until we get a new response from passwordsStorage.list() the user can see and even interact with the old list of items, which may still contain the just deleted one. To avoid users seeing obsolete logins or even interacting with them (selecting a previosuly deleted item will result in a crash) we will clean the list of logins just before the selected login is opened in the detailed view. When returning for a brief moment the users may see the "loading" UX until passwordsStorage.list() returns the up-to-date list of logins to display. * For #11227 - Refactor SavedLoginsView to be closer to MVI - Interactors should only get passed other Interactors or Controllers as dependencies to which they should delegate user actions. - Controllers should hold most of the business logic and get passed all final dependencies they need to do their job.	4 years ago
Tiger Oakes	294f29768d	Test logins settings	4 years ago