Commit Graph

125 Commits (023a4983fa769a6fb9eea6600ec7ce8e620618c4)

Author SHA1 Message Date
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
4 years ago
jhugman 9df13ae121
For #11655: add leanplum event for installing an addon (#12136) r=elise
* For #11655: add leanplum event for installing an addon

* Add link to data-review request in PR

* Addressed CI comments
4 years ago
Sachin 4b9cc954fa
for #11830 added new metric for collecting startup method from all startup phases (#11940)
* for #11830 added new metric for collecting startup method

move all source startup telemetry into its own logic and added an UNKOWN state

* switched back to onNewIntent solution

* renamed the metric
4 years ago
Sawyer Blatz 8a08cb941e
For #11479: Record open tabs count in metrics ping (#12024) 4 years ago
Sawyer Blatz 101ecfbf66
For #11273: Add tabs tray telemetry (#12036) 4 years ago
Sawyer Blatz 04aee11d82
For #9625: Add telemetry for Tracking Protection CFR (#11923) 4 years ago
Elise Richards 665fb8d60c
#10824: Onboarding telemetry (#11867)
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
4 years ago
Sawyer Blatz 2d65faf232
For #11392: Rename Installation ping to FirstSession (#11869) 4 years ago
person808 9e3e95e351 For #11442 - Telemetry for tab counter menu. 4 years ago
Sawyer Blatz fffbadbfca
For #11118: Add browsing history suggestion in metrics (#11525) 4 years ago
Sawyer Blatz 13d077eb66
For #11269: Telemetry for new reader mode position (#11385) 4 years ago
Sawyer Blatz d1cd877374 For #11118: Add missing telemetry 4 years ago
Sawyer Blatz 9302d07d13 For #11118: Add toggle states to metrics ping 4 years ago
Gabriel Luong 9520c9dd32 For #8920 - [Telemetry] Send add-on ids in a metrics ping 4 years ago
Sawyer Blatz b06be1fcde For #9488 Add telemetry for search widget CFR 4 years ago
Sawyer Blatz 7067e5c000
For #8125: Add default top site telemetry (#10752) 4 years ago
Sawyer Blatz 477493e197
For #10465: Add telemetry for voice search (#10785) 4 years ago
ValentinTimisica 15dfe0811d For #10343: Updates metrics accordingly to 'Library' removal 4 years ago
Mihai Branescu f09bc4566c For #6557 - added metric for in_content 4 years ago
Mihai Branescu 93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 4 years ago
Vlad Filippov e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event
Fixes #9834
4 years ago
Sawyer Blatz dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 4 years ago
Michael Droettboom 3789f50423 Fix errors in top_sites_count metric
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
4 years ago
Gabriel Luong dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 4 years ago
ekager 96c6401457 For #8125 - Send top sites count with metrics ping 4 years ago
Grisha Kruglov be1fa8df7d Pre: introduce a RunWhenReadyQueue
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
4 years ago
Sawyer Blatz a356b4b2c4
For #9136: Send all adjust properties to glean (#9253) 4 years ago
Sawyer Blatz b9059c8208
For #9256: Attempts to fix installation ping not being sent (#9254) 4 years ago
Jim Porter ec98fd948b For #7847: Improve startup performance of the Fenix wrapper around Glean 4 years ago
Harshal Lele e318cd7d15 fix #8135 - remove getColorFromAttr 4 years ago
codrut.topliceanu d6ae3d4abe For #7295 - Adds new custom ping: 'installation' 4 years ago
ekager b72550c28a For #8126 - Adds default top sites 4 years ago
Mugurell ad1144c722 For #6577 - Remove the `total_uri_count` Glean StringMetricType
This was added as a duplicate to an already existing `total_uri_count`
CounterMetricType in #4456.
4 years ago
Jeff Boek 127169f5ff For mozilla-mobile#8172: Add a new 'E_Fennec_To_Fenix_Migrated' Leanplum event
This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.

Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
4 years ago
Jeff Boek 952c48c8ce For #4674 - Adds ability to toggle metric services by type 4 years ago
ValentinTimisica 0a76fdaa58 For #7289: Adds telemetry for selecting dark theme 4 years ago
ValentinTimisica 2026c60136 For #6834: Adds telemetry for About page items
Didn't change the existing probe for 'whats new' item because we're already
collecting that info.
4 years ago
Gabriel Luong f93e141d52 For #7525 - Add telemetry for opening a top site in normal and private mode and removing a top site 4 years ago
ekager c556e819bd For #5586 - Add telemetry for save logins setting 4 years ago
Mihai Adrian 355cb35cb6 For #7574: Send toolbar position metrics in English. (#7712) 4 years ago
Sawyer Blatz 509fa112d0 For #6308: Remove unecessary telemetry & bump expiry date (#7793)
* For #6308: Remove unecessary telemetry

* For #6308: Bump expiry date on telemetry
4 years ago
ValentinTimisica c106d89285 For #7751: Remove 'SearchWithCustomEngine' telemetry event 4 years ago
Sebastian Kaspari 29d9ba472c Always initialize glean. Set upload flag after migration. (#7717) 4 years ago
Alessio Placitelli f93437c509 Fix GleanMetricsService to use the new Glean APIs 4 years ago
ValentinTimisica 7c5c9355ce For #5884: Adds user-specified search engines telemetry
Created events for adding and deleting a custom search engine and for searches
performed with a custom search engine.
4 years ago
Will Hawkins 9c28cb632c Issue #7425 (et al): Cache the list of installed browsers
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
4 years ago
mcarare c3389dcdb5 For #6070 Adds telemetry for enabling search suggestions in private 5 years ago
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
5 years ago
Gabriel Luong c6562bff98 For #5583 - Adds telemetry for download notification (#6554) 5 years ago
Will Hawkins 7173bdf0b1 Issue #6196: Make initialization of Glean metrics faster
setStartupMetrics is very expensive and does not need to be
done synchronously at the time the Glean Metrics Service is
initialized.
5 years ago