Commit Graph

41 Commits (issues/111-temp-icon)

Author SHA1 Message Date
Adam Novak 5097afad8e Put the (not itself OSS?) license plugin back so we can keep the license screen 4 years ago
Adam Novak ba91b74887 Apply liberate patch
Apply https://gitlab.com/relan/fennecbuild/-/blob/master/fenix-liberate.patch
at edac9bd4083644ae0b8ae04e6af719892f05ee3a

License sign-off from author "relan" in
https://gitlab.com/relan/fennecbuild/-/issues/4#note_404430753

"Note that fenix-liberate.patch is a copypaste from various projects under
Apache 2.0 and MPL 2.0. I've made only trivial changes and it makes sense to
distribute them under MPL 2.0 or Apache 2.0, not AGPL.

I think I need to add license headers to all new files added by the patch."

We can pick up additional license headers if and when they're added by relan.
Almost all the code is trivial, probably-uncopyrightable stubs.

We might be supposed to put more info in the licenses screen in the app, which
I'm keeping, for some of these, but I'm not sure how.
4 years ago
Tiger Oakes d762dea49d Gradle configuration avoidance 4 years ago
Tiger Oakes 7f9ddfe051 For #13404: Update Android lint URL 4 years ago
Tiger Oakes acbce3dcc2
Closes #13404: Update github checks URL (#13407) 4 years ago
Tiger Oakes 61d6b333de Update LongParameterList baseline 4 years ago
liuche 09d0688e64
CI for PR #9705 (#12748)
* #3880. Update detekt to 1.9.1

* #3880. Use `AbsentOrWrongFileLicense` detekt rule

* #3880. Update detekt baseline

Co-authored-by: Denys M <dector9@gmail.com>
4 years ago
Tiger Oakes da87727c61
Add links in Checks panel for test/lint tasks (#12222)
* Add lints in Checks panel for test/lint tasks

* Switch to custom task

* Rename github tasks
4 years ago
Tiger Oakes a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 4 years ago
Johan Lorenzo 714c2c849d
Bug 1625126 - Cache external dependencies in a single task and let gradle tasks use it (#10316) 4 years ago
Michael Comella f0464b9e72
For #9644: restrict deps to specific repositories (#9649)
* For #9644: remove unnecessary leanplum maven repository.

The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.

[1]: https://docs.leanplum.com/reference#android-setup

* For #9644: move buildscript block from :app to root project.

This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.

* For #9644: restrict dependencies following FFTV config.

However, there is a resolution error to be fixed in the next commit.

This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.

Source:
  62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
  62a2fa680c/build.gradle (L31)

* For #9644: restrict firebase deps to google repo.

This fixes the resolution error from the previous PR.
4 years ago
Emily Kager b94ac93ce9
Upgrade to detekt 1.6.0 (#9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes #7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
4 years ago
Sebastian Kaspari 34144fd254 Use pinned Android Components Nightly version instead of snapshots. 4 years ago
Will Hawkins f69009aa9e No Issue: Add custom detekt rule to blacklist certain properties
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
4 years ago
Colin Lee a8f895cb5c
For #4064: Replace prerelease R8 with improved Kotlin coroutines library (#7153) 4 years ago
Gabriel 56b21426eb
For #5574 - Migrate SessionControl to LibState (#6651)
* For #5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (#6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For #5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (#6651)

In #2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For #5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (#6651)

* For #5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (#6651)

- Removes TabAction

* For #5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 15: Introduce a HomeFragmentStore (#6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For #5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (#6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For #5574 - Part 20: Remove the architecture module. (#6651)

* For #5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (#6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For #5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (#6651)

* For #5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (#6651)

- Renames SessionControlUIView to SessionControlView

* For #5574 - Part 21: Fix white screen on home fragment (#6651)

* For #5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (#6651)

* For #5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (#6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For #5574 - Part 24: Use the sessionManager getter in SessionControlController (#6651)

* For #5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (#6651)

* For #5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (#6651)

* For #5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (#6651)

* For #5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (#6651)

* For #5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (#6651)

* For #5574 - Removes running CI against the architecture debug build varient
4 years ago
Colin Lee 66b2969077
For #4064: Old R8 & keep rules are inhibiting optimizations (#4930) 5 years ago
Jeff Boek 68f5d211d3 For #4326 - Updates codebase to support latest version of detekt 5 years ago
Jeff Boek e601fe7c9f For #4326 - Updates codebase to support latest version of ktlint 5 years ago
Sawyer Blatz d9c2c0d16a For #4326: Update detekt and ktlint dependenies 5 years ago
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 5 years ago
Colin Lee a514cb3f8c No issue: Add OSS licenses link to About page 5 years ago
Stefan Arentz ff5eca1537 Fixes #445 - Ship Fenix x86_64 builds (#2856) 5 years ago
Ryan Kelly 17f8e236aa Closes #2555: Remove appservices gradle plugin, perform megazord substitution by hand. 5 years ago
Grisha Kruglov 6476836069 Remove custom appservices repository
Appservices artifacts are now being manually mirrored to m.m.o.
Eventually, they will be automatically published to m.m.o
5 years ago
Colin Lee bd81e72239 Fixes #916, fixes #917, fixes #920: Save, share, and delete bookmarks 5 years ago
Grisha Kruglov 0e19e6f55e Declare appservices repository dependency explicitly 5 years ago
Colin Lee 0ac3e5369d Fixes #1050: Fenix sessions save and close upon opening 5 years ago
Colin Lee 72b9d4ebdb No issue: Upgrade to stable Navigation library and ignore ktlint issues in generated code 5 years ago
Colin Lee 6e1655e935 Fix #1032: Crash altering sessions DB on main thread 5 years ago
Jeff Boek 521ca74836 Fixes #891 - Adds the leanplum sdk 5 years ago
Grisha Kruglov 9a9740bfd3 Issue #309: Consume Fenix megazord; enable Rust logging 5 years ago
Colin Lee 5cf61c95db Fixes #589: Add sample unit tests for a component 5 years ago
Colin Lee f09dc2453f Fixes #351 Create home screen component for multitasking 5 years ago
Sebastian Kaspari 344bc0aea6 Move architecture/mvi code to separate gradle module. 5 years ago
Colin Lee 99a72fc7f4 Add detekt, ktlint, and upgrade Gradle wrapper 5 years ago
Jeff Boek 3e0ed05c0e Adds missing licenses 5 years ago
Jeff Boek 560aea9b56 For #141 - wires up toolbar and awesomebar 5 years ago
Stefan Arentz c72834479e Update Android Components to 0.39-SNAPSHOT 5 years ago
Colin Lee 6449a7b798 Fix buildSrc dependencies and androidX usages 5 years ago
Jeff Boek e34f7e166d Initializes Android project
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
5 years ago