Commit Graph

34 Commits (fenix/124.1.0)

Author SHA1 Message Date
mcarare aba7bb120b Bug 1821005 - Restore reverted Gradle 8 upgrade due to startup crashes"
This reverts commit 592e88b3547d2e96ae04d8b5bd69cbab2ac3e97e.
6 months ago
Geoff Brown 310a5a99f7 Bug 1825116 - Resolve many lint issues found on oak (#4551)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
6 months ago
Ryan VanderMeulen e46a3545ae Bug 1821005 - Revert Gradle 8 upgrade due to startup crashes
Revert "Bug 1863744 - Update Gradle to version 8.4"

This reverts commit 829795632954148709fbe945c78d55cc62053ac8.

Revert "Bug 1821005 - Apply additional keep rules for missing classes detected while running R8."

This reverts commit 8f3f246cc5ff571323f56d46963d8d176bec91e3.

Revert "Bug 1821005 - Set UI_INJECTION_HOST mode for lint in test."

This reverts commit 6962bf0b5df57781045f68417f76527bcdf521ab.

Revert "Bug 1821005 -  Include sourcesJar as an input of publishing."

This reverts commit 41b2a48da577787c3189eec8c8af71c35cfecbfb.

Revert "Bug 1821005 - Set compileOptions for android subprojects."

This reverts commit fb21df9d0a9cd585e216733dc1bf929636df20f1.

Revert "Bug 1821005 - Replace deprecated project.buildDir"

This reverts commit 6f880de46ec73f7e5240a0279108bbb6aeb0f63b.

Revert "Bug 1821005 - Exclude generated metrics docs from detekt."

This reverts commit f17d2430bf1daabeed2724312354018050f3f52a.

Revert "Bug 1821005 - Exclude build in extensions versioning from detekt."

This reverts commit 34144c5ad1d62e2d85492f8d32341bbcd032690b.

Revert "Bug 1821005 - Add uses-feature tag for camera permission."

This reverts commit 13c80944bd1756cdcaa98eef783b6a23ad12cabd.

Revert "Bug 1821005 - Set nonTransitiveRClass and nonFinalResIds build flags to false."

This reverts commit 219fbc19c54134ad264edc79642fa1799c6f54d6.

Revert "Bug 1821005 - Apply plugin: 'kotlin-android' for UI modules."

This reverts commit ddbd5e18eb9d2b33b4de4a6df48d97ec4ab42963.

Revert "Bug 1821005 - Enable generation of the BuildConfig class"

This reverts commit 65c2b8c63790fbd2352f3f94b99c80d81d18dae1.

Revert "Bug 1821005 - Add namespace to samples-glean-library module"

This reverts commit 0239233efb1cc4e896e4aa0337e3da911eeb2f1c.

Revert "Bug 1821005 - Replace deprecated toLowerCase with lowercase."

This reverts commit 69f2c66aad3aa638a1bab31b2a1e6c597d1f3992.

Revert "Bug 1821005 - Replace deprecated 'toInt' method with 'code' property."

This reverts commit 7adb38a6fbe20de3fdb6723a10e574d183e7fcff.

Revert "Bug 1821005 - Replace deprecated execResult."

This reverts commit bfd02dd16d7e5c9dbcf34858fbbe4176d698f8cd.

Revert "Bug 1849833 - Replace deprecated extractNativeLibs manifest attribute."

This reverts commit a05bc9618457ab2d71a5d3d88d8d3b0318497a54.

Revert "Bug 1821005 - Upgrade AGP to 8.0.2"

This reverts commit fc0fadd63553e2144ce074454d502ecf307eb988.

Revert "Bug 1821005 - Upgrade kotlin-dsl to 4.1.0."

This reverts commit 14e8903e922fa22e28450520be3b6152be6a3a8f.

Revert "Bug 1821005 - Upgrade Gradle to 8.3 version."

This reverts commit f14f447a4d43588d24e4ca3efde0668ddcf7cf08.
6 months ago
mcarare 4c9122603c Bug 1821005 - Set UI_INJECTION_HOST mode for lint in test. 6 months ago
Gabriel Luong 584ffcff9d Bug 1837107 - Unify FenixDependencies with AC's DependenciesPlugin 11 months ago
mcarare 133a9c2810 Bug 1831352 - Target Java 17. 11 months ago
Ryan VanderMeulen fcd5d5c6ae Bug 1820233 - Remove unneeded kotlin_stdlib inclusions and re-enable Werror in detekt build.gradle 1 year ago
mcarare 5a0b9d754d Bug 1813671 - Target JVM 11 bytecode
See https://developer.android.com/studio/releases/gradle-plugin#jvm-11-bytecode for details.
1 year ago
Gabriel Luong 47ba3a90ef [fenix] Bug 1804820 - Refactor Versions to FenixVersions 1 year ago
Gabriel Luong 9afbd1bc46 [fenix] Bug 1804820 - Refactor Deps to FenixDependencies 1 year ago
Gabriel Luong 1ec4cf8dad [fenix] For https://github.com/mozilla-mobile/fenix/issues/27667 - Remove import-ordering from the list of disabled ktlint rules 2 years ago
mcarare 1816aa7d00 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26023: Run lint test only once.
Avoids running with added extra whitespaces.
2 years ago
Mugurell 785a42edfd [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Remove the Kotlin synthetics Lint detector
Since all usages of Kotlin synthetics are removed and no such code is generated
anymore there is no need to keep around this Detector anymore.
3 years ago
Mugurell 75aeb961e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Add a Kotlin synthetics Lint detector
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
3 years ago
Sebastian Kaspari d0717965a9 [fenix] Allow insecure protocol usage when using local Nexus in CI. 3 years ago
Sebastian Kaspari f5852e29e7 [fenix] Use new lint API. 3 years ago
Michael Comella 4493b90366 [fenix] No issue: move relevant files in :mozilla-lint-rules to perf pkg. 4 years ago
Michael Comella 9ddef29862 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15707: add ConstraintLayoutPerfDetectorTest.
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
4 years ago
Michael Comella cb07bf265d [fenix] For https://github.com/mozilla-mobile/fenix/issues/15707: remove super.visitElement for ConstraintLayout lint.
It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
4 years ago
Michael Comella 3f31e4cc1b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15707: clean up lint rules dependencies.
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
4 years ago
ekager 2ae46088f6 [fenix] No issue - Update lint detector tests to run 4 years ago
Juan C. Goncalves a3fce6b92d [fenix] For https://github.com/mozilla-mobile/fenix/issues/11397 - Add lint rule for AppCompatResources instead of ContextCompat (https://github.com/mozilla-mobile/fenix/pull/16011) 4 years ago
Sebastian Kaspari 9c7e0ad770 [fenix] Update Android Components, Kotlin, Gradle plugin (https://github.com/mozilla-mobile/fenix/pull/16021)
* Closes https://github.com/mozilla-mobile/fenix/issues/13262: Update AGP to 4

* Update to Mozilla Android Components 63.0.20201019090011.

* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.

* Fix new compiler warnings.

* Fix compilation of lint rules module.

* Pin JNA version.

* Fix new lint errors.

Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Juan C. Goncalves a68b2b2ec0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8947 - Lint check for licenses in Kotlin/Java source files (https://github.com/mozilla-mobile/fenix/pull/15639) 4 years ago
ekager 74b4866e3d [fenix] Fixes existing lint errors 4 years ago
Michael Comella 0e8148f253 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: update Android Gradle Plugin version.
This ensures our custom lint rules are running on the command line.
4 years ago
Michael Comella de1a390dba [fenix] For https://github.com/mozilla-mobile/fenix/issues/15280: add ConstraintLayoutPerfDetector custom lint rule. 4 years ago
Michael Comella 095078a325 [fenix] No issue: minimize Button...Detector violation location.
This changes the error highlighting from being the entire contents of
<Button ...> to just the first line of <Button>.
4 years ago
TangHuaiZhe 20e0787404 [fenix] Update mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/TextViewAndroidSrcXmlDetector.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
4 years ago
Tang HuaiZhe 43861331e7 [fenix] Fix the comment of TextViewAndroidSrcXmlDetector. 4 years ago
Elise Richards fc847d79e7 [fenix] No issue: Delete unnecessary to-dos (https://github.com/mozilla-mobile/fenix/pull/12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Mihai Branescu bff1eb12c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8643 and https://github.com/mozilla-mobile/fenix/issues/7606 - added styles and new colors 4 years ago
Sawyer Blatz e33e84bcbc [fenix] For https://github.com/mozilla-mobile/fenix/issues/9857: Create button style (https://github.com/mozilla-mobile/fenix/pull/9858)
* For https://github.com/mozilla-mobile/fenix/issues/9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
4 years ago
ekager ccee01a230 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8944 - Adds custom lint checks 4 years ago