Commit Graph

99 Commits (fenix/123.1.0)

Author SHA1 Message Date
isabelrios abff667349 [fenix] Stop depending on JCenter - Screengrab and Falcon 3 years ago
Sebastian Kaspari 21b40d89d8 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819: Update detekt to 1.17.1 3 years ago
Sebastian Kaspari 7c11a19369 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040: Remove Leanplum (Nightly) 3 years ago
Sebastian Kaspari 41c5267ba7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819: Pull trove4j from Maven Central instead of JCenter. 3 years ago
Sebastian Kaspari 23e25d8f8f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819: Get leanplum artifacts from leanplum repository. 3 years ago
Sebastian Kaspari 186570c1ba [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819: Only use JCenter for specific dependencies. 3 years ago
Sebastian Kaspari 63d0555ee4 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819: Remove JCenter from buildscript repositories. 3 years ago
Sebastian Kaspari d676df89fb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17819: Add Maven Central repository. 3 years ago
Michael Comella 0e8148f253 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15644: update Android Gradle Plugin version.
This ensures our custom lint rules are running on the command line.
4 years ago
Michael Comella 7e5cad1e66 [fenix] No issue: run detekt on unit test files.
detekt still passes after I make this change.

afaik, there isn't a good reason not to run it on unit tests and it can
be valuable to add custom rules for them. Also, detekt is already
running on our androidTest directory.
4 years ago
Tiger Oakes 053781ffbd [fenix] Gradle configuration avoidance 4 years ago
Tiger Oakes d9fe2f0cc9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13404: Update Android lint URL 4 years ago
Tiger Oakes 3d046dcfa2 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/13404: Update github checks URL (https://github.com/mozilla-mobile/fenix/pull/13407) 4 years ago
Tiger Oakes 233708b122 [fenix] Update LongParameterList baseline 4 years ago
liuche 8932298651 [fenix] CI for PR https://github.com/mozilla-mobile/fenix/pull/9705 (https://github.com/mozilla-mobile/fenix/pull/12748)
* https://github.com/mozilla-mobile/fenix/issues/3880. Update detekt to 1.9.1

* https://github.com/mozilla-mobile/fenix/issues/3880. Use `AbsentOrWrongFileLicense` detekt rule

* https://github.com/mozilla-mobile/fenix/issues/3880. Update detekt baseline

Co-authored-by: Denys M <dector9@gmail.com>
4 years ago
Tiger Oakes 8171bef320 [fenix] Add links in Checks panel for test/lint tasks (https://github.com/mozilla-mobile/fenix/pull/12222)
* Add lints in Checks panel for test/lint tasks

* Switch to custom task

* Rename github tasks
4 years ago
Tiger Oakes 01faa91808 [fenix] Migrate some SessionManager usage to BrowserStore (https://github.com/mozilla-mobile/fenix/pull/10789) 4 years ago
Johan Lorenzo 8413ec21bc [fenix] Bug 1625126 - Cache external dependencies in a single task and let gradle tasks use it (https://github.com/mozilla-mobile/fenix/pull/10316) 4 years ago
Michael Comella de6bbb791a [fenix] For https://github.com/mozilla-mobile/fenix/issues/9644: restrict deps to specific repositories (https://github.com/mozilla-mobile/fenix/pull/9649)
* For https://github.com/mozilla-mobile/fenix/issues/9644: remove unnecessary leanplum maven repository.

The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.

[1]: https://docs.leanplum.com/reference#android-setup

* For https://github.com/mozilla-mobile/fenix/issues/9644: move buildscript block from :app to root project.

This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.

* For https://github.com/mozilla-mobile/fenix/issues/9644: restrict dependencies following FFTV config.

However, there is a resolution error to be fixed in the next commit.

This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.

Source:
  62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
  62a2fa680c/build.gradle (L31)

* For https://github.com/mozilla-mobile/fenix/issues/9644: restrict firebase deps to google repo.

This fixes the resolution error from the previous PR.
4 years ago
Emily Kager 522aca44f4 [fenix] Upgrade to detekt 1.6.0 (https://github.com/mozilla-mobile/fenix/pull/9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes https://github.com/mozilla-mobile/fenix/issues/7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
4 years ago
Sebastian Kaspari 4169924754 [fenix] Use pinned Android Components Nightly version instead of snapshots. 4 years ago
Will Hawkins 78e86d8f2b [fenix] No Issue: Add custom detekt rule to blacklist certain properties
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
4 years ago
Colin Lee a9a3fdc1fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Replace prerelease R8 with improved Kotlin coroutines library (https://github.com/mozilla-mobile/fenix/pull/7153) 5 years ago
Gabriel 9ed4f7f119 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState (https://github.com/mozilla-mobile/fenix/pull/6651)
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651)

In https://github.com/mozilla-mobile/fenix/issues/2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- Removes TabAction

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651)

- Renames SessionControlUIView to SessionControlView

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
5 years ago
Colin Lee b472ab03be [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Old R8 & keep rules are inhibiting optimizations (https://github.com/mozilla-mobile/fenix/pull/4930) 5 years ago
Jeff Boek 6ec0801d0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of detekt 5 years ago
Jeff Boek 40ae66fdbb [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of ktlint 5 years ago
Sawyer Blatz f6a3eff2e1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326: Update detekt and ktlint dependenies 5 years ago
Sawyer Blatz 8bd4dc98d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4508: Treats warnings as errors (https://github.com/mozilla-mobile/fenix/pull/4543) 5 years ago
Colin Lee 32ec775443 [fenix] No issue: Add OSS licenses link to About page 5 years ago
Stefan Arentz 264f522b37 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/445 - Ship Fenix x86_64 builds (https://github.com/mozilla-mobile/fenix/pull/2856) 5 years ago
Ryan Kelly 36686f3fd8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2555: Remove appservices gradle plugin, perform megazord substitution by hand. 5 years ago
Grisha Kruglov 59f9a71777 [fenix] Remove custom appservices repository
Appservices artifacts are now being manually mirrored to m.m.o.
Eventually, they will be automatically published to m.m.o
5 years ago
Colin Lee 6311a7abd1 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/916, fixes https://github.com/mozilla-mobile/fenix/issues/917, fixes https://github.com/mozilla-mobile/fenix/issues/920: Save, share, and delete bookmarks 5 years ago
Grisha Kruglov e7e1e8503e [fenix] Declare appservices repository dependency explicitly 5 years ago
Colin Lee 447b6c9526 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1050: Fenix sessions save and close upon opening 5 years ago
Colin Lee 0a8fe6ad18 [fenix] No issue: Upgrade to stable Navigation library and ignore ktlint issues in generated code 5 years ago
Colin Lee 5cf2fa2389 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/1032: Crash altering sessions DB on main thread 5 years ago
Jeff Boek cf151c0c1a [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/891 - Adds the leanplum sdk 5 years ago
Grisha Kruglov 0898d23c69 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/309: Consume Fenix megazord; enable Rust logging 5 years ago
Colin Lee 3aeaac9459 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/589: Add sample unit tests for a component 5 years ago
Colin Lee d6e79694f8 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/351 Create home screen component for multitasking 5 years ago
Sebastian Kaspari b3d56e5720 [fenix] Move architecture/mvi code to separate gradle module. 5 years ago
Colin Lee f8f79d843f [fenix] Add detekt, ktlint, and upgrade Gradle wrapper 5 years ago
Jeff Boek b87e93ed12 [fenix] Adds missing licenses 5 years ago
Jeff Boek 5639c641a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/141 - wires up toolbar and awesomebar 5 years ago
Stefan Arentz 2e70d02ddb [fenix] Update Android Components to 0.39-SNAPSHOT 5 years ago
Colin Lee b76a058d3e [fenix] Fix buildSrc dependencies and androidX usages 5 years ago
Jeff Boek 06f1bf6471 [fenix] Initializes Android project
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
6 years ago