Added `surface_powered_by_fakespot_link_clicked` telemetry probe
that is sent when the user taps the "Powered by Fakespot by Mozilla"
footer link in Review Checker Sheet.
Using `.inc()` was wrong due to it returning the incremented
value and not incrementing the already existing one. This
patch aims to fix that, therefore showing the CFR correctly
for max 3 times.
This commit:
* Adds an `AwesomeBarView.SearchResultFilter` type, with variants to
only include results for the current search engine (`CurrentEngine`)
and exclude results with a matching query parameter
(`ExcludeSponsored`).
* Adds a `String.urlContainsQueryParameters` extension function for
using the `ExcludeSponsored` filter with the synced tabs provider.
* Refactors the `AwesomeBarView.get*Provider` methods to take an
optional `SearchResultFilter`.
This commit:
* Changes the bookmarks, history, session, and synced tabs suggestion
providers to take an optional predicate that filters matching
suggestions by `Uri` (bookmarks, history, session) or URL string
(synced tabs), instead of comparing the suggestions' URLs directly.
* Hoists the host matching checks out of the providers.
The current onboarding CFR is set to show the first time someone
lands on a product detail page. If the user dismisses the CFR and
does not opt-in, we show it on the next product detail page after at
least 24 hours have elapsed.
This patch changes this to showing the CFR up to 3X (instead of 2)
with at least 12 hrs in-between (instead of 24).
This commit:
* Adds new facts, `wikipedia_suggestion_clicked` and
`wikipedia_suggestion_impressed`, to the `feature-fxsuggest`
component.
* Emits `fx-suggest` Glean pings for those facts in Fenix's
`MetricController`.
In Firefox Desktop, sponsored and non-sponsored suggestions aren't
shown in private windows, even when the "Show search suggestions in
Private Windows" option is checked. This commit makes Fenix's behavior
match Desktop's.
We recently made a change to the shopping CFRs that made them harder
to dismiss. They can only be dismissed by clicking the close X or
by clicking the link that opens the bottom sheet. The issue is that
this results in the page and the UI being unresponsive. So we want
to revert back to the original behavior where they were
dismissible by clicking outside. This change currently only affects
the shopping CFR
Expandable sections states in review checker bottom sheet were not
announce when using talkback. This patch adds both the states and
the actions that need to be dictated.
Noah Bond
Roger Yang
DreVla
AndiAJ
rahulsainani
github-actions
Harrison Oglesby
Ben Dean-Kawamura
James Hugman
Lina Butler
Ryan VanderMeulen
JohanLorenzo
Arturo Mejia
Gabriel Luong
oana.horvath
iorgamgabriel
alexandra.virvara
t-p-white
mike a