This change comes to use the shared LoginsFragmentStore and help elide a more
expensive read from disk for updated logins by using the in memory data for
instant updates in all Fragments interested in LoginsFragmentStore updates.
This reverts the recent patch for bug 1799622 and reworks the implementation to
avoid using the Fragment Result API for a simpler functionality using the
already shared LoginsFragmentStore.
This brings multiple advantages over the current implementation:
- we're not creating a new instance of SavedLoginsFragment
- we avoid a deeper and more expensive layer of caching the just added login
through SyncableLoginsStorage and use the in memory data.
- we avoid having to intercept the back press to control navigation
This helps to reduce theme color duplication, making it easier to see
which parameters differ.
This also brings FirefoxColors closer to the upstream Compose Material
Colors class.
* Add "Open all in new tabs" options in bookmarks
* Add "Open all in private tabs" options in bookmarks
* Add metrics tracking if the usage of "Open all in..." in bookmarks
Co-authored-by: Pg <pg.developper.fr@gmail.com>
PocketStoriesChange was called only once - to clean the shown stories when the
user gets to the homescreen and the Pocket feature is disabled - useful for the
situations in which the user returns after disabling the feature in settings.
Populating the store with recommended stories to show was already happening
based on 'PocketStoriesCategoriesChange' and sponsored stories will be added by
using 'PocketSponsoredStoriesChange' so renaming 'PocketStoriesChange' will
help on reducing any confusion in the future.
Also added documentation for all Pocket related actions from AppStore and
removed the 'UndocumentedPublicClass' detekt suppressions.
Gabriel Luong
iTrooz
mcarare
Roger Yang
Ryan VanderMeulen
Mugurell
Geoff Brown
jhugman
Noah Bond
Alexander Gramiak
mcarare
Pg
Alexandru2909
Brais Gabín