Commit Graph

22 Commits (describe-install)

Author SHA1 Message Date
Michael Comella d2467f7541 For #13959 - post: ignore new StrictMode rule in tests. 4 years ago
Michael Comella 3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 4 years ago
Michael Comella f690f8736d No issue: replace LintUnitTestRunner with detekt implementation.
This should be more performant and easier to maintain.
4 years ago
Kainalu Hagiwara 52d4ffdef0 For #13424 - Fix detekt config and warnings. 4 years ago
Matthew Finkel b0c187b7e7 For #13363: Update pre-push-recommended's flavor 4 years ago
Tiger Oakes 61d6b333de Update LongParameterList baseline 4 years ago
Tiger Oakes 52de2b8f38 Fix license on remaining files 4 years ago
liuche 09d0688e64
CI for PR #9705 (#12748)
* #3880. Update detekt to 1.9.1

* #3880. Use `AbsentOrWrongFileLicense` detekt rule

* #3880. Update detekt baseline

Co-authored-by: Denys M <dector9@gmail.com>
4 years ago
Denys M ff3e738794 #12169. Fix pre-push hook instructions. 4 years ago
Emily Kager b94ac93ce9
Upgrade to detekt 1.6.0 (#9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes #7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
4 years ago
Michael Comella c0d7a1f759 No issue: pre-push: assemble everything before testing.
It's better to fail fast on pre-push hooks so devs can get feedback as
fast as possible. Assembling is faster than unit testing so we assemble
everything first before unit testing.
4 years ago
Will Hawkins f69009aa9e No Issue: Add custom detekt rule to blacklist certain properties
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
4 years ago
Michael Comella 7d754cc60e No issue: make pre-push hook assemble only one variant, run tests, build UI test.
Since it's redundant to the definition in the source, I intend to remove
the pre-push hook listed in the wiki after this merges.
4 years ago
Jeff Boek 68f5d211d3 For #4326 - Updates codebase to support latest version of detekt 5 years ago
Mitchell Hentges 6c020a0bc4 Configure either geckoview beta or nightly at compile-time (#4851)
* Remove "abi" product flavor and introduce "engine" product flavor.

This patch will allow us to build Fenix against GeckoView Nightly and GeckoView Beta by
introducing a new flavor dimension: engine = [geckoNightly, geckoBeta].

In addition to that it adds a "fenix"  prefix to the nightly, beta and production flavors
to reduce the ambiguity between fenix beta/nightly and GeckoView beta/nightly.

For now the build types have the following engine variants enabled:

**debug**: geckoNightly, geckoBeta
Both variants enabled for local development and testing.

**forPerformanceTest**: geckoNightly, geckoBeta
Both variants enabled unless the perf team only cares about Nightly (tbd)

**fenixNightlyLegacy**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). This release type will eventualyl be decommissioned once we switch to a separate
Nightly app on Google Play.

**fenixNightly**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). Changing this build to use GeckoView Nightly is currently being discussed.

**fenixBeta**: geckoBeta
Fenix Beta uses GeckoView Beta.

**fenixProduction**
Fenix Production uses GeckoView Beta (69) currently.

* gradle.py/variant.py: Replace "abi" with "engine".

* Disable enableUnitTestBinaryResources until we can switch to Android Gradle plugin 3.5.

* Fenix nightly should use both geckoview nightly and beta

* Updates automation to use apk splitting and support different engine
5 years ago
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 5 years ago
Mitchell Hentges 92b6d4a925 Moves release flavour to build type (#1693) 5 years ago
ekager 052ab2383f No issue: Add instructions to pre-push hook 5 years ago
Sebastian Kaspari 0bffc071b6 Closes #698: Create product flavors for Fennec transition.
* greenfield (pure Fenix without anything added)
* firefoxNightly (To replace Firefox Nightly)
* firefoxBeta (To replace Firefox Beta)
* firefoxRelease (To replace Firefox Release)

For now it will be a bit annoying to have all those flavors. But once the transition has been
successfully completed we can start to tear them down again.

Once GeckoView universal builds are available we can get rid of the "abi" dimension.

If this is going to slow down the CI process then I might look into parallelizing the build
or potentially introducing a taskcluster CI setup (if that makes sense).
5 years ago
Sebastian Kaspari 9876970b16 Mark pre-push-recommended as executable. 5 years ago
Colin Lee 8af55652be Add project README and pre-push-hook 5 years ago
Colin Lee b2b6a530d0 Make ktlint and detekt style changes 5 years ago