From fce3d1186e9ebccfb9547a66063f53ca1a4b182c Mon Sep 17 00:00:00 2001 From: Abhijit Kiran Valluri Date: Tue, 29 Sep 2020 16:35:33 +0100 Subject: [PATCH] Homepage improvements (closes #29, #64, #146, #171) (#184) Some improvements to the Homescreen! * Do not show collections placeholder in home screen on a clean install and subsequently as well. * Increase the limit for top sites to 160 * Show 20 top sites on the screen at a time, before pagination occurs. --- app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt | 2 +- .../home/sessioncontrol/viewholders/TopSitePagerViewHolder.kt | 2 +- app/src/main/java/org/mozilla/fenix/utils/Settings.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index 97fb25474..72c55c61a 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -208,7 +208,7 @@ class HomeFragment : Fragment() { ) ).getTip() }, - showCollectionPlaceholder = components.settings.showCollectionsPlaceholderOnHome + showCollectionPlaceholder = false ) ) } diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TopSitePagerViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TopSitePagerViewHolder.kt index 23e59a081..89b6ac0a9 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TopSitePagerViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TopSitePagerViewHolder.kt @@ -61,6 +61,6 @@ class TopSitePagerViewHolder( companion object { const val LAYOUT_ID = R.layout.component_top_sites_pager const val TOP_SITES_MAX_PAGE_SIZE = 2 - const val TOP_SITES_PER_PAGE = 8 + const val TOP_SITES_PER_PAGE = 20 } } diff --git a/app/src/main/java/org/mozilla/fenix/utils/Settings.kt b/app/src/main/java/org/mozilla/fenix/utils/Settings.kt index 75f5a6edd..8adf28ae0 100644 --- a/app/src/main/java/org/mozilla/fenix/utils/Settings.kt +++ b/app/src/main/java/org/mozilla/fenix/utils/Settings.kt @@ -52,7 +52,7 @@ private const val AUTOPLAY_USER_SETTING = "AUTOPLAY_USER_SETTING" class Settings(private val appContext: Context) : PreferencesHolder { companion object { - const val topSitesMaxCount = 16 + const val topSitesMaxCount = 160 const val FENIX_PREFERENCES = "fenix_preferences" private const val BLOCKED_INT = 0