From efdb1172ef358ba825c47511ec890495de7f94ff Mon Sep 17 00:00:00 2001 From: Rahul Sainani Date: Thu, 1 Dec 2022 18:43:38 +0100 Subject: [PATCH] For mozilla-mobile#26736 - fix username validation error state (#28017) --- .../fenix/settings/logins/fragment/AddLoginFragment.kt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/AddLoginFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/AddLoginFragment.kt index 9e26aaada..af63477a6 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/AddLoginFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/AddLoginFragment.kt @@ -195,8 +195,10 @@ class AddLoginFragment : Fragment(R.layout.fragment_add_login), MenuProvider { binding.usernameText.addTextChangedListener( object : TextWatcher { - override fun afterTextChanged(u: Editable?) { - usernameChanged = true + override fun afterTextChanged(editable: Editable?) { + // update usernameChanged to true when the text is not empty, + // otherwise it is not changed, as this screen starts with an empty username. + usernameChanged = editable.toString().isNotEmpty() updateUsernameField() setSaveButtonState() findDuplicate()