diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeHistoryTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeHistoryTest.kt index 4614e7fef..7ad95d13e 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeHistoryTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/ComposeHistoryTest.kt @@ -75,7 +75,7 @@ class ComposeHistoryTest { } @Test - fun noHistoryItemsInCacheTest() { + fun verifyEmptyHistoryMenuTest() { homeScreen { }.openThreeDotMenu { verifyHistoryButton() @@ -87,8 +87,9 @@ class ComposeHistoryTest { // Test running on beta/release builds in CI: // caution when making changes to it, so they don't block the builds + @SmokeTest @Test - fun visitedUrlHistoryTest() { + fun verifyHistoryMenuWithHistoryItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -104,6 +105,7 @@ class ComposeHistoryTest { verifyVisitedTimeTitle() verifyFirstTestPageTitle("Test_Page_1") verifyTestPageUrl(firstWebPage.url) + verifyDeleteHistoryItemButton("Test_Page_1") } } } @@ -128,50 +130,6 @@ class ComposeHistoryTest { } } - @Test - fun undoDeleteHistoryItemTest() { - val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) - - navigationToolbar { - }.enterURLAndEnterToBrowser(firstWebPage.url) { - mDevice.waitForIdle() - }.openThreeDotMenu { - }.openHistory { - verifyHistoryListExists() - registerAndCleanupIdlingResources( - RecyclerViewIdlingResource(activityTestRule.activity.findViewById(R.id.history_list), 1), - ) { - clickDeleteHistoryButton(firstWebPage.url.toString()) - } - verifyUndoDeleteSnackBarButton() - clickUndoDeleteButton() - verifyHistoryItemExists(true, firstWebPage.url.toString()) - } - } - - @SmokeTest - @Test - fun cancelDeleteAllHistoryTest() { - val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) - - navigationToolbar { - }.enterURLAndEnterToBrowser(firstWebPage.url) { - mDevice.waitForIdle() - }.openThreeDotMenu { - }.openHistory { - verifyHistoryListExists() - registerAndCleanupIdlingResources( - RecyclerViewIdlingResource(activityTestRule.activity.findViewById(R.id.history_list), 1), - ) { - clickDeleteAllHistoryButton() - } - verifyDeleteConfirmationMessage() - selectEverythingOption() - cancelDeleteHistory() - verifyHistoryItemExists(true, firstWebPage.url.toString()) - } - } - @SmokeTest @Test fun deleteAllHistoryTest() { @@ -226,7 +184,7 @@ class ComposeHistoryTest { @Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1807268") @Test - fun openHistoryInNewTabTest() { + fun openMultipleSelectedHistoryItemsInANewTabTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -255,7 +213,7 @@ class ComposeHistoryTest { } @Test - fun openHistoryInPrivateTabTest() { + fun openMultipleSelectedHistoryItemsInPrivateTabTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -280,7 +238,7 @@ class ComposeHistoryTest { } @Test - fun deleteMultipleSelectionTest() { + fun deleteMultipleSelectedHistoryItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) val secondWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 2) @@ -314,7 +272,7 @@ class ComposeHistoryTest { } @Test - fun shareButtonTest() { + fun shareMultipleSelectedHistoryItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/HistoryTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/HistoryTest.kt index f6c662538..8526f3186 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/HistoryTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/HistoryTest.kt @@ -73,8 +73,9 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/243285 @Test - fun noHistoryItemsInCacheTest() { + fun verifyEmptyHistoryMenuTest() { homeScreen { }.openThreeDotMenu { verifyHistoryButton() @@ -84,10 +85,12 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/2302742 // Test running on beta/release builds in CI: // caution when making changes to it, so they don't block the builds + @SmokeTest @Test - fun visitedUrlHistoryTest() { + fun verifyHistoryMenuWithHistoryItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -103,34 +106,16 @@ class HistoryTest { verifyVisitedTimeTitle() verifyFirstTestPageTitle("Test_Page_1") verifyTestPageUrl(firstWebPage.url) + verifyDeleteHistoryItemButton("Test_Page_1") } } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/243288 @Test fun deleteHistoryItemTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) - navigationToolbar { - }.enterURLAndEnterToBrowser(firstWebPage.url) { - mDevice.waitForIdle() - }.openThreeDotMenu { - }.openHistory { - verifyHistoryListExists() - registerAndCleanupIdlingResources( - RecyclerViewIdlingResource(activityTestRule.activity.findViewById(R.id.history_list), 1), - ) { - clickDeleteHistoryButton(firstWebPage.url.toString()) - } - verifyDeleteSnackbarText("Deleted") - verifyEmptyHistoryView() - } - } - - @Test - fun undoDeleteHistoryItemTest() { - val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) - navigationToolbar { }.enterURLAndEnterToBrowser(firstWebPage.url) { mDevice.waitForIdle() @@ -145,12 +130,16 @@ class HistoryTest { verifyUndoDeleteSnackBarButton() clickUndoDeleteButton() verifyHistoryItemExists(true, firstWebPage.url.toString()) + clickDeleteHistoryButton(firstWebPage.url.toString()) + verifyDeleteSnackbarText("Deleted") + verifyEmptyHistoryView() } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/1848881 @SmokeTest @Test - fun cancelDeleteAllHistoryTest() { + fun deleteAllHistoryTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -168,25 +157,7 @@ class HistoryTest { selectEverythingOption() cancelDeleteHistory() verifyHistoryItemExists(true, firstWebPage.url.toString()) - } - } - - @SmokeTest - @Test - fun deleteAllHistoryTest() { - val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) - - navigationToolbar { - }.enterURLAndEnterToBrowser(firstWebPage.url) { - mDevice.waitForIdle() - }.openThreeDotMenu { - }.openHistory { - verifyHistoryListExists() - registerAndCleanupIdlingResources( - RecyclerViewIdlingResource(activityTestRule.activity.findViewById(R.id.history_list), 1), - ) { - clickDeleteAllHistoryButton() - } + clickDeleteAllHistoryButton() verifyDeleteConfirmationMessage() selectEverythingOption() confirmDeleteAllHistory() @@ -195,7 +166,7 @@ class HistoryTest { } } - @SmokeTest + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/339690 @Test fun historyMultiSelectionToolbarItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) @@ -223,9 +194,10 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/339696 @Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1807268") @Test - fun openHistoryInNewTabTest() { + fun openMultipleSelectedHistoryItemsInANewTabTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -253,8 +225,9 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/346098 @Test - fun openHistoryInPrivateTabTest() { + fun openMultipleSelectedHistoryItemsInPrivateTabTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -278,8 +251,9 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/346099 @Test - fun deleteMultipleSelectionTest() { + fun deleteMultipleSelectedHistoryItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) val secondWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 2) @@ -312,8 +286,9 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/339701 @Test - fun shareButtonTest() { + fun shareMultipleSelectedHistoryItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) navigationToolbar { @@ -338,6 +313,7 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/1715627 @Test fun verifySearchHistoryViewTest() { val defaultWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) @@ -380,6 +356,7 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/1715631 @Test fun verifyVoiceSearchInHistoryTest() { homeScreen { @@ -392,6 +369,7 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/1715632 @Test fun verifySearchForHistoryItemsTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) @@ -421,6 +399,7 @@ class HistoryTest { } } + // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/1715634 @Test fun verifyDeletedHistoryItemsCanNotBeSearchedTest() { val firstWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HistoryRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HistoryRobot.kt index dcf4a8c88..0cd61c723 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HistoryRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/HistoryRobot.kt @@ -82,6 +82,9 @@ class HistoryRobot { deleteButton(item).click() } + fun verifyDeleteHistoryItemButton(historyItemTitle: String) = + deleteButton(historyItemTitle).check(matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE))) + fun clickDeleteAllHistoryButton() = deleteButton().click() fun selectEverythingOption() = deleteHistoryEverythingOption().click() diff --git a/automation/taskcluster/androidTest/flank-arm-beta.yml b/automation/taskcluster/androidTest/flank-arm-beta.yml index eac00bc0e..6774ab503 100644 --- a/automation/taskcluster/androidTest/flank-arm-beta.yml +++ b/automation/taskcluster/androidTest/flank-arm-beta.yml @@ -20,7 +20,7 @@ gcloud: performance-metrics: true test-targets: - - class org.mozilla.fenix.ui.HistoryTest#visitedUrlHistoryTest + - class org.mozilla.fenix.ui.HistoryTest#verifyHistoryMenuWithHistoryItemsTest - class org.mozilla.fenix.ui.SettingsSearchTest#toggleSearchSuggestionsTest - class org.mozilla.fenix.ui.CollectionTest#deleteCollectionTest - class org.mozilla.fenix.ui.SmokeTest#noHistoryInPrivateBrowsingTest diff --git a/automation/taskcluster/androidTest/flank-arm-legacy-api-tests.yml b/automation/taskcluster/androidTest/flank-arm-legacy-api-tests.yml index 7a7465c1e..6977ad7b9 100644 --- a/automation/taskcluster/androidTest/flank-arm-legacy-api-tests.yml +++ b/automation/taskcluster/androidTest/flank-arm-legacy-api-tests.yml @@ -25,7 +25,7 @@ gcloud: - notPackage org.mozilla.fenix.experimentintegration - class org.mozilla.fenix.ui.MainMenuTest#goBackTest - class org.mozilla.fenix.ui.MainMenuTest#goForwardTest - - class org.mozilla.fenix.ui.HistoryTest#visitedUrlHistoryTest + - class org.mozilla.fenix.ui.HistoryTest#verifyHistoryMenuWithHistoryItemsTest - class org.mozilla.fenix.ui.SettingsSearchTest#toggleSearchSuggestionsTest - class org.mozilla.fenix.ui.CollectionTest#deleteCollectionTest - class org.mozilla.fenix.ui.SmokeTest#noHistoryInPrivateBrowsingTest diff --git a/automation/taskcluster/androidTest/flank-arm-start-test.yml b/automation/taskcluster/androidTest/flank-arm-start-test.yml index 540ddc145..82e2006c6 100644 --- a/automation/taskcluster/androidTest/flank-arm-start-test.yml +++ b/automation/taskcluster/androidTest/flank-arm-start-test.yml @@ -20,7 +20,7 @@ gcloud: performance-metrics: true test-targets: - - class org.mozilla.fenix.ui.HistoryTest#visitedUrlHistoryTest + - class org.mozilla.fenix.ui.HistoryTest#verifyHistoryMenuWithHistoryItemsTest - class org.mozilla.fenix.ui.SettingsSearchTest#toggleSearchSuggestionsTest - class org.mozilla.fenix.ui.CollectionTest#deleteCollectionTest - class org.mozilla.fenix.ui.SmokeTest#noHistoryInPrivateBrowsingTest