For #16676 - Do not switch mode on last private tab via tab context menu

upstream-sync
ekager 4 years ago committed by Christian Sadilek
parent 94c59cb3ca
commit d49d710343

@ -13,7 +13,6 @@ import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.browser.BrowserAnimator.Companion.getToolbarNavOptions
import org.mozilla.fenix.browser.BrowserFragmentDirections
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.browser.readermode.ReaderModeController
import org.mozilla.fenix.components.metrics.Event
import org.mozilla.fenix.components.metrics.MetricController
@ -108,8 +107,6 @@ class DefaultBrowserToolbarController(
sessionManager.selectedSession?.let {
// When closing the last tab we must show the undo snackbar in the home fragment
if (sessionManager.sessionsOfType(it.private).count() == 1) {
// The tab tray always returns to normal mode so do that here too
activity.browsingModeManager.mode = BrowsingMode.Normal
homeViewModel.sessionToDelete = it.id
navController.navigate(
BrowserFragmentDirections.actionGlobalHome()

@ -208,7 +208,6 @@ class DefaultBrowserToolbarControllerTest {
@Test
fun handleToolbarCloseTabPressWithLastPrivateSession() {
val browsingModeManager = SimpleBrowsingModeManager(BrowsingMode.Private)
val item = TabCounterMenu.Item.CloseTab
val sessions = listOf(
mockk<Session> {
@ -218,7 +217,6 @@ class DefaultBrowserToolbarControllerTest {
every { currentSession.private } returns true
every { sessionManager.sessions } returns sessions
every { activity.browsingModeManager } returns browsingModeManager
val controller = createController()
controller.handleTabCounterItemInteraction(item)
@ -226,7 +224,6 @@ class DefaultBrowserToolbarControllerTest {
homeViewModel.sessionToDelete = "1"
navController.navigate(BrowserFragmentDirections.actionGlobalHome())
}
assertEquals(BrowsingMode.Normal, browsingModeManager.mode)
}
@Test

Loading…
Cancel
Save