From d2ff0bb65d36aa2b20b0a99039b11597c9cafeab Mon Sep 17 00:00:00 2001
From: William Durand <will+git@drnd.me>
Date: Mon, 21 Aug 2023 13:58:22 +0200
Subject: [PATCH] Bug 1849329 - Update local GV docs

We do not need to patch the build system to read the GeckoView version anymore.
---
 docs/substituting-local-gv.md | 30 ++++++------------------------
 1 file changed, 6 insertions(+), 24 deletions(-)

diff --git a/docs/substituting-local-gv.md b/docs/substituting-local-gv.md
index 868e7d716..27605c3ca 100644
--- a/docs/substituting-local-gv.md
+++ b/docs/substituting-local-gv.md
@@ -1,26 +1,8 @@
 # Substituting local GeckoView
 
 ### 1. Manually publish local GeckoView to local Maven
-First, to get the version that we are locally publishing (which will be used in later steps) please add the following:
 
-*geckoview/build.gradle*
-```diff
-diff --git a/mobile/android/geckoview/build.gradle b/mobile/android/geckoview/build.gradle
-index 731026796921b..81cc6782be291 100644
---- a/mobile/android/geckoview/build.gradle
-+++ b/mobile/android/geckoview/build.gradle
-@@ -398,6 +398,7 @@ android.libraryVariants.all { variant ->
- apply plugin: 'maven-publish'
- 
- version = getVersionNumber()
-+println("version = " + version)
- group = 'org.mozilla.geckoview'
- 
- def getArtifactId() {
-
-```
-
-We can now publish our local GeckoView to our local maven.
+Publish our local GeckoView to our local maven:
 ```sh
 ./mach build && ./mach gradle \
     geckoview:publishWithGeckoBinariesDebugPublicationToMavenLocal \
@@ -29,17 +11,17 @@ We can now publish our local GeckoView to our local maven.
 
 :warning: **This needs to be run every time you make changes.** :warning:
 
-You need to copy the version in the logs or run 
+You need to copy the version in the logs or run:
 ```sh
 ./mach build | grep version
-``` 
+```
 (ex. `115.0.20230511122045-SNAPSHOT`)
 
 ### 2. Modify Fenix to consume local GV
 Update the build.gradle and Gecko.kt file in Fenix (see the diffs below). Remember to update the GV version with the version you found in step 2!
 
 *fenix/build.gradle*
-```diff 
+```diff
 diff --git a/fenix/build.gradle b/fenix/build.gradle
 index 6a635a4818..4c8cc28995 100644
 --- a/fenix/build.gradle
@@ -73,7 +55,7 @@ index bed3fb0161..2d3a19a96e 100644
       */
 -    const val version = "115.0.20230511131014"
 +    const val version = "115.0.20230511122045-SNAPSHOT"
- 
+
      /**
       * GeckoView channel
 @@ -23,7 +23,7 @@ object Gecko {
@@ -89,6 +71,6 @@ index bed3fb0161..2d3a19a96e 100644
 ```
 
 ### 3. Build fenix with local GV
-Now sync your gradle changes and build! 
+Now sync your gradle changes and build!
 
 An easy way to confirm you are using a local GV is switching your Android Studio project tool window to "Project" and looking in the root directory called "External Libraries" for "GeckoView". You should see something like `Gradle: org.mozilla.geckoview-default-omni:115.0.20230511122045-SNAPSHOT@aar`