Clean up logic to return margin pairs for readability

5 years ago · d285e799b9
parent 14fe356d62
commit d285e799b9
1 changed files with 7 additions and 2 deletions
--- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt
+++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt
@ -394,12 +394,17 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope {
        swipeRefresh.apply {
            val toolbarAndQASSize = resources.getDimension(R.dimen.toolbar_and_qab_height).toInt()
            val toolbarSize = resources.getDimension(R.dimen.browser_toolbar_height).toInt()
+            val (topMargin, bottomMargin) = when {
+                inFullScreen -> Pair(0, 0)
+                customTabSessionId == null -> Pair(0, toolbarAndQASSize)
+                else -> Pair(toolbarSize, 0)
+            }
            (layoutParams as CoordinatorLayout.LayoutParams).apply {
                setMargins(
                    0,
-                    if (customTabSessionId == null || inFullScreen) 0 else toolbarSize,
+                    topMargin,
                    0,
-                    if (inFullScreen) 0 else if (customTabSessionId == null) toolbarAndQASSize else 0
+                    bottomMargin
                )
            }
        }