For #25437: Fix label values for labeled counters.

pull/543/head
mcarare 2 years ago committed by mergify[bot]
parent 47aba0b0ff
commit d20ba1d0fe

@ -110,7 +110,7 @@ class RecentSyncedTabFeature(
lastSyncedTab: RecentSyncedTab?,
syncStartId: GleanTimerId?
) {
RecentSyncedTabs.recentSyncedTabShown[tab.deviceType.name].add()
RecentSyncedTabs.recentSyncedTabShown[tab.deviceType.name.lowercase()].add()
RecentSyncedTabs.recentSyncedTabTimeToLoad.stopAndAccumulate(syncStartId)
if (tab == lastSyncedTab) {
RecentSyncedTabs.latestSyncedTabIsStale.add()

@ -41,7 +41,7 @@ class DefaultRecentSyncedTabController(
private val accessPoint: TabsTrayAccessPoint,
) : RecentSyncedTabController {
override fun handleRecentSyncedTabClick(tab: RecentSyncedTab) {
RecentSyncedTabs.recentSyncedTabOpened[tab.deviceType.name].add()
RecentSyncedTabs.recentSyncedTabOpened[tab.deviceType.name.lowercase()].add()
addNewTabUseCase.invoke(tab.url)
navController.navigate(R.id.browserFragment)
}

@ -134,7 +134,7 @@ class TabsTrayFragment : AppCompatDialogFragment() {
val args by navArgs<TabsTrayFragmentArgs>()
args.accessPoint.takeIf { it != TabsTrayAccessPoint.None }?.let {
TabsTray.accessPoint[it.name].add()
TabsTray.accessPoint[it.name.lowercase()].add()
}
val initialMode = if (args.enterMultiselect) {
TabsTrayState.Mode.Select(emptySet())

@ -185,7 +185,7 @@ class RecentSyncedTabFeatureTest {
feature.displaySyncedTabs(listOf(tab))
assertEquals(1, RecentSyncedTabs.recentSyncedTabShown[deviceAccessed1.deviceType.name].testGetValue())
assertEquals(1, RecentSyncedTabs.recentSyncedTabShown["desktop"].testGetValue())
}
@Test

@ -102,7 +102,7 @@ class DefaultRecentSyncedTabControllerTest {
controller.handleRecentSyncedTabClick(tab)
assertEquals(1, RecentSyncedTabs.recentSyncedTabOpened[deviceType.name].testGetValue())
assertEquals(1, RecentSyncedTabs.recentSyncedTabOpened["desktop"].testGetValue())
}
@Test

Loading…
Cancel
Save