From ce80610473e7127cc4d266979190e634ff20cff3 Mon Sep 17 00:00:00 2001 From: Lina Butler Date: Sat, 3 Feb 2024 11:49:05 -0800 Subject: [PATCH] Bug 1878434 - Record an awesomebar abandonment for cancelled toolbar edits. We were missing instrumentation for the case where the user cancels editing. This commit adds that instrumentation. --- .../java/org/mozilla/fenix/search/SearchDialogController.kt | 1 + .../org/mozilla/fenix/search/SearchDialogControllerTest.kt | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/search/SearchDialogController.kt b/app/src/main/java/org/mozilla/fenix/search/SearchDialogController.kt index 74e830fce..4ab17e66a 100644 --- a/app/src/main/java/org/mozilla/fenix/search/SearchDialogController.kt +++ b/app/src/main/java/org/mozilla/fenix/search/SearchDialogController.kt @@ -143,6 +143,7 @@ class SearchDialogController( override fun handleEditingCancelled() { clearToolbarFocus() dismissDialogAndGoBack() + store.dispatch(AwesomeBarAction.EngagementFinished(abandoned = true)) } override fun handleTextChanged(text: String) { diff --git a/app/src/test/java/org/mozilla/fenix/search/SearchDialogControllerTest.kt b/app/src/test/java/org/mozilla/fenix/search/SearchDialogControllerTest.kt index fcb7fb6f8..d1e10dcfe 100644 --- a/app/src/test/java/org/mozilla/fenix/search/SearchDialogControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/search/SearchDialogControllerTest.kt @@ -313,6 +313,10 @@ class SearchDialogControllerTest { assertTrue(clearToolbarFocusInvoked) assertTrue(dismissAndGoBack) + + middleware.assertLastAction(AwesomeBarAction.EngagementFinished::class) { action -> + assertTrue(action.abandoned) + } } @Test