From cc35c2f3eddc83a3a7b4e9c2d6afeeb1177af064 Mon Sep 17 00:00:00 2001 From: Chris Peterson Date: Wed, 13 Sep 2023 10:23:10 -0700 Subject: [PATCH] Bug 1848842 - Increase APK regression alert's threshold to 1 MB We added a regression alert for APK size regressions greater than 100 KB (in bug 1838717). This 100 KB threshold is too sensitive, so instead of disabling it entirely, I'd like to increase the threshold to 1 MB, so we will at least catch big surprises like -O2 bug 1838709 (+3 MB) and ICUX bug 1848025 (+2 MB). --- plugins/apksize/src/main/java/ApkSizePlugin.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/apksize/src/main/java/ApkSizePlugin.kt b/plugins/apksize/src/main/java/ApkSizePlugin.kt index dd42b2650..a327cee09 100644 --- a/plugins/apksize/src/main/java/ApkSizePlugin.kt +++ b/plugins/apksize/src/main/java/ApkSizePlugin.kt @@ -107,7 +107,7 @@ open class ApkSizeTask : DefaultTask() { suite.put("value", getSummarySize(apkSize)) suite.put("lowerIsBetter", true) suite.put("alertChangeType", "absolute") - suite.put("alertThreshold", 100 * 1024) + suite.put("alertThreshold", 1024 * 1024) val subtests = JSONArray() apkSize.forEach { (apk, size) ->