From ca7896ad4bee8926c4d0b3583e164032ca1eb21f Mon Sep 17 00:00:00 2001 From: t-p-white Date: Thu, 18 Jan 2024 12:26:34 +0000 Subject: [PATCH] Bug 1874861 - Removed redundant LongParameterList suppression's --- .../java/org/mozilla/fenix/AppRequestInterceptor.kt | 1 - app/src/main/java/org/mozilla/fenix/HomeActivity.kt | 3 +-- .../org/mozilla/fenix/browser/infobanner/DynamicInfoBanner.kt | 1 - .../java/org/mozilla/fenix/browser/infobanner/InfoBanner.kt | 1 - .../mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt | 2 +- .../mozilla/fenix/components/toolbar/ToolbarIntegration.kt | 1 - app/src/main/java/org/mozilla/fenix/compose/Image.kt | 1 - app/src/main/java/org/mozilla/fenix/compose/TabThumbnail.kt | 1 - app/src/main/java/org/mozilla/fenix/compose/ThumbnailImage.kt | 1 - .../org/mozilla/fenix/compose/list/ExpandableListHeader.kt | 1 - .../java/org/mozilla/fenix/compose/tabstray/TabGridItem.kt | 2 +- .../java/org/mozilla/fenix/compose/tabstray/TabListItem.kt | 3 +-- .../java/org/mozilla/fenix/debugsettings/tabs/TabTools.kt | 1 - app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt | 1 - .../org/mozilla/fenix/home/pocket/PocketStoriesComposables.kt | 3 +-- .../fenix/home/recentsyncedtabs/view/RecentSyncedTab.kt | 2 +- .../fenix/home/sessioncontrol/SessionControlAdapter.kt | 1 - app/src/main/java/org/mozilla/fenix/home/topsites/TopSites.kt | 3 +-- .../library/history/viewholders/HistoryListItemViewHolder.kt | 1 - .../main/java/org/mozilla/fenix/search/SearchFragmentStore.kt | 1 - .../java/org/mozilla/fenix/settings/SyncPreferenceView.kt | 1 - .../mozilla/fenix/settings/search/SearchEngineShortcuts.kt | 3 +-- .../org/mozilla/fenix/settings/wallpaper/WallpaperSettings.kt | 3 --- .../shopping/ui/ReviewQualityCheckContextualOnboarding.kt | 2 +- .../java/org/mozilla/fenix/tabstray/NavigationInteractor.kt | 2 +- app/src/main/java/org/mozilla/fenix/tabstray/TabsTray.kt | 2 +- .../main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt | 4 ++-- .../main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt | 1 - .../main/java/org/mozilla/fenix/tabstray/TrayPagerAdapter.kt | 1 - .../fenix/tabstray/browser/AbstractBrowserTabViewHolder.kt | 1 - .../mozilla/fenix/tabstray/browser/InactiveTabViewHolder.kt | 1 - .../org/mozilla/fenix/tabstray/browser/InactiveTabsAdapter.kt | 1 - .../org/mozilla/fenix/translations/TranslationsBottomSheet.kt | 1 - .../downloadlanguages/DownloadLanguageFileDialog.kt | 1 - app/src/main/java/org/mozilla/fenix/utils/Undo.kt | 1 - .../java/org/mozilla/fenix/wallpapers/WallpaperOnboarding.kt | 2 -- .../fenix/components/TrackingProtectionPolicyFactoryTest.kt | 1 - .../toolbar/DefaultBrowserToolbarMenuControllerTest.kt | 1 - .../mozilla/fenix/library/bookmarks/BookmarkControllerTest.kt | 1 - .../controller/HistoryMetadataGroupControllerTest.kt | 1 - .../org/mozilla/fenix/tabstray/NavigationInteractorTest.kt | 1 - .../tabstray/browser/AbstractBrowserTabViewHolderTest.kt | 1 - 42 files changed, 13 insertions(+), 51 deletions(-) diff --git a/app/src/androidTest/java/org/mozilla/fenix/AppRequestInterceptor.kt b/app/src/androidTest/java/org/mozilla/fenix/AppRequestInterceptor.kt index b474245a3..a8be915ad 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/AppRequestInterceptor.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/AppRequestInterceptor.kt @@ -92,7 +92,6 @@ class AppRequestInterceptor( // This method is the only difference from the production code. // Otherwise the code should be kept identical - @Suppress("LongParameterList") private fun interceptFxaRequest( engineSession: EngineSession, uri: String, diff --git a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt index 9c8b4a734..00f5e766b 100644 --- a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt +++ b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt @@ -148,7 +148,7 @@ import java.util.Locale * - home screen * - browser screen */ -@SuppressWarnings("TooManyFunctions", "LargeClass", "LongParameterList", "LongMethod") +@SuppressWarnings("TooManyFunctions", "LargeClass", "LongMethod") open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity { // DO NOT MOVE ANYTHING ABOVE THIS, GETTING INIT TIME IS CRITICAL // we need to store startup timestamp for warm startup. we cant directly store @@ -960,7 +960,6 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity { * was opened from history. * @param additionalHeaders The extra headers to use when loading the URL. */ - @Suppress("LongParameterList") fun openToBrowserAndLoad( searchTermOrURL: String, newTab: Boolean, diff --git a/app/src/main/java/org/mozilla/fenix/browser/infobanner/DynamicInfoBanner.kt b/app/src/main/java/org/mozilla/fenix/browser/infobanner/DynamicInfoBanner.kt index 132369dcb..379da8bb3 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/infobanner/DynamicInfoBanner.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/infobanner/DynamicInfoBanner.kt @@ -22,7 +22,6 @@ import androidx.coordinatorlayout.widget.CoordinatorLayout * @param dismissAction Optional callback invoked when the user dismisses the banner. * @param actionToPerform The action to be performed on action button press. */ -@Suppress("LongParameterList") class DynamicInfoBanner( private val context: Context, container: ViewGroup, diff --git a/app/src/main/java/org/mozilla/fenix/browser/infobanner/InfoBanner.kt b/app/src/main/java/org/mozilla/fenix/browser/infobanner/InfoBanner.kt index 1cefa8529..3c2b31bdb 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/infobanner/InfoBanner.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/infobanner/InfoBanner.kt @@ -26,7 +26,6 @@ import org.mozilla.fenix.ext.settings * @property dismissAction Optional callback invoked when the user dismisses the banner. * @param actionToPerform The action to be performed on action button press. */ -@SuppressWarnings("LongParameterList") open class InfoBanner( private val context: Context, private val container: ViewGroup, diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt index 4a47a63aa..c820a384c 100644 --- a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt @@ -54,7 +54,7 @@ import org.mozilla.fenix.theme.ThemeManager * @param pinnedSiteStorage Used to check if the current url is a pinned site. * @property isPinningSupported true if the launcher supports adding shortcuts. */ -@Suppress("LargeClass", "LongParameterList", "TooManyFunctions") +@Suppress("LargeClass", "TooManyFunctions") open class DefaultToolbarMenu( private val context: Context, private val store: BrowserStore, diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt index eb458ea2e..94a927d2a 100644 --- a/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt +++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt @@ -76,7 +76,6 @@ abstract class ToolbarIntegration( } } -@Suppress("LongParameterList") class DefaultToolbarIntegration( context: Context, toolbar: BrowserToolbar, diff --git a/app/src/main/java/org/mozilla/fenix/compose/Image.kt b/app/src/main/java/org/mozilla/fenix/compose/Image.kt index a9db9f4ca..e1c321bb6 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/Image.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/Image.kt @@ -41,7 +41,6 @@ import org.mozilla.fenix.theme.FirefoxTheme * By default set to a solid color in [DefaultImagePlaceholder]. */ @Composable -@Suppress("LongParameterList") fun Image( url: String, modifier: Modifier = Modifier, diff --git a/app/src/main/java/org/mozilla/fenix/compose/TabThumbnail.kt b/app/src/main/java/org/mozilla/fenix/compose/TabThumbnail.kt index 3e77de1d6..373283529 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/TabThumbnail.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/TabThumbnail.kt @@ -42,7 +42,6 @@ private const val FALLBACK_ICON_SIZE = 36 * @param alignment [Alignment] used to draw the image content. */ @Composable -@Suppress("LongParameterList") fun TabThumbnail( tab: TabSessionState, storage: ThumbnailStorage, diff --git a/app/src/main/java/org/mozilla/fenix/compose/ThumbnailImage.kt b/app/src/main/java/org/mozilla/fenix/compose/ThumbnailImage.kt index 1bdb4c553..34707d484 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/ThumbnailImage.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/ThumbnailImage.kt @@ -38,7 +38,6 @@ import org.mozilla.fenix.theme.FirefoxTheme * @param fallbackContent The content to display with a thumbnail is unable to be loaded. */ @Composable -@Suppress("LongParameterList") fun ThumbnailImage( request: ImageLoadRequest, storage: ThumbnailStorage, diff --git a/app/src/main/java/org/mozilla/fenix/compose/list/ExpandableListHeader.kt b/app/src/main/java/org/mozilla/fenix/compose/list/ExpandableListHeader.kt index d729dec68..9a595a4f7 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/list/ExpandableListHeader.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/list/ExpandableListHeader.kt @@ -38,7 +38,6 @@ import org.mozilla.fenix.theme.FirefoxTheme * @param onClick Optional lambda for handling header clicks. * @param actions Optional Composable for adding UI to the end of the header. */ -@Suppress("LongParameterList") @Composable fun ExpandableListHeader( headerText: String, diff --git a/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabGridItem.kt b/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabGridItem.kt index 26b135283..02ee66a30 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabGridItem.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabGridItem.kt @@ -91,7 +91,7 @@ import org.mozilla.fenix.theme.FirefoxTheme */ @OptIn(ExperimentalMaterialApi::class, ExperimentalFoundationApi::class) @Composable -@Suppress("MagicNumber", "LongParameterList", "LongMethod") +@Suppress("MagicNumber", "LongMethod") fun TabGridItem( tab: TabSessionState, storage: ThumbnailStorage, diff --git a/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabListItem.kt b/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabListItem.kt index 054cb4509..0563af574 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabListItem.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/tabstray/TabListItem.kt @@ -75,7 +75,7 @@ import org.mozilla.fenix.theme.FirefoxTheme */ @OptIn(ExperimentalFoundationApi::class, ExperimentalMaterialApi::class) @Composable -@Suppress("MagicNumber", "LongMethod", "LongParameterList") +@Suppress("MagicNumber", "LongMethod") fun TabListItem( tab: TabSessionState, storage: ThumbnailStorage, @@ -209,7 +209,6 @@ private fun clickableColor() = when (isSystemInDarkTheme()) { } @Composable -@Suppress("LongParameterList") private fun Thumbnail( tab: TabSessionState, size: Int, diff --git a/app/src/main/java/org/mozilla/fenix/debugsettings/tabs/TabTools.kt b/app/src/main/java/org/mozilla/fenix/debugsettings/tabs/TabTools.kt index ca68b140f..c6daa5d80 100644 --- a/app/src/main/java/org/mozilla/fenix/debugsettings/tabs/TabTools.kt +++ b/app/src/main/java/org/mozilla/fenix/debugsettings/tabs/TabTools.kt @@ -104,7 +104,6 @@ private fun generateTabList( } @Composable -@Suppress("LongParameterList") private fun TabToolsContent( activeTabCount: Int, inactiveTabCount: Int, diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt b/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt index 6a2dfedf7..7a94a7837 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeMenuView.kt @@ -47,7 +47,6 @@ import org.mozilla.fenix.GleanMetrics.HomeMenu as HomeMenuMetrics * clicked. * @param fxaEntrypoint The source entry point to FxA. */ -@Suppress("LongParameterList") class HomeMenuView( private val view: View, private val context: Context, diff --git a/app/src/main/java/org/mozilla/fenix/home/pocket/PocketStoriesComposables.kt b/app/src/main/java/org/mozilla/fenix/home/pocket/PocketStoriesComposables.kt index 3b224dc82..db81bc244 100644 --- a/app/src/main/java/org/mozilla/fenix/home/pocket/PocketStoriesComposables.kt +++ b/app/src/main/java/org/mozilla/fenix/home/pocket/PocketStoriesComposables.kt @@ -239,7 +239,7 @@ fun PocketSponsoredStory( * @param onDiscoverMoreClicked Callback for when the user taps an element which contains an */ @OptIn(ExperimentalComposeUiApi::class) -@Suppress("LongParameterList", "LongMethod") +@Suppress("LongMethod") @Composable fun PocketStories( @PreviewParameter(PocketStoryProvider::class) stories: List, @@ -367,7 +367,6 @@ private fun alignColumnToTitlePadding(screenWidth: Dp, contentPadding: Dp) = * @param onCategoryClick Callback for when the user taps a category. */ @OptIn(ExperimentalComposeUiApi::class) -@Suppress("LongParameterList") @Composable fun PocketStoriesCategories( categories: List, diff --git a/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/view/RecentSyncedTab.kt b/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/view/RecentSyncedTab.kt index d999471e4..fa58db55c 100644 --- a/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/view/RecentSyncedTab.kt +++ b/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/view/RecentSyncedTab.kt @@ -69,7 +69,7 @@ private const val THUMBNAIL_SIZE = 108 * @param onRemoveSyncedTab Invoked when user clicks on the "Remove" dropdown menu option. */ @OptIn(ExperimentalFoundationApi::class) -@Suppress("LongMethod", "LongParameterList") +@Suppress("LongMethod") @Composable fun RecentSyncedTab( tab: RecentSyncedTab?, diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt index 258ded268..ff9326010 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt @@ -190,7 +190,6 @@ class AdapterItemDiffCallback : DiffUtil.ItemCallback() { } } -@Suppress("LongParameterList") class SessionControlAdapter( private val interactor: SessionControlInteractor, private val viewLifecycleOwner: LifecycleOwner, diff --git a/app/src/main/java/org/mozilla/fenix/home/topsites/TopSites.kt b/app/src/main/java/org/mozilla/fenix/home/topsites/TopSites.kt index 53d4aaddc..a2bfcc3ae 100644 --- a/app/src/main/java/org/mozilla/fenix/home/topsites/TopSites.kt +++ b/app/src/main/java/org/mozilla/fenix/home/topsites/TopSites.kt @@ -239,7 +239,7 @@ data class TopSiteColors( * @param onTopSiteLongClick Invoked when the user long clicks on a top site. * @param onTopSitesItemBound Invoked during the composition of a top site item. */ -@Suppress("LongParameterList", "LongMethod") +@Suppress("LongMethod") @OptIn(ExperimentalFoundationApi::class, ExperimentalComposeUiApi::class) @Composable private fun TopSiteItem( @@ -401,7 +401,6 @@ private fun TopSiteFavicon(url: String, imageUrl: String? = null) { } @Composable -@Suppress("LongParameterList") private fun getMenuItems( topSite: TopSite, onOpenInPrivateTabClicked: (topSite: TopSite) -> Unit, diff --git a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt index 154cee636..d94c4a187 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt @@ -54,7 +54,6 @@ class HistoryListItemViewHolder( * @param groupPendingDeletionCount allows to properly display the number of items inside a * history group, taking into account pending removal of items inside. */ - @Suppress("LongParameterList") fun bind( item: History, timeGroup: HistoryItemTimeGroup?, diff --git a/app/src/main/java/org/mozilla/fenix/search/SearchFragmentStore.kt b/app/src/main/java/org/mozilla/fenix/search/SearchFragmentStore.kt index ead8dddac..816700d7d 100644 --- a/app/src/main/java/org/mozilla/fenix/search/SearchFragmentStore.kt +++ b/app/src/main/java/org/mozilla/fenix/search/SearchFragmentStore.kt @@ -140,7 +140,6 @@ data class SearchFragmentState( /** * Creates the initial state for the search fragment. */ -@Suppress("LongParameterList") fun createInitialSearchFragmentState( components: Components, tabId: String?, diff --git a/app/src/main/java/org/mozilla/fenix/settings/SyncPreferenceView.kt b/app/src/main/java/org/mozilla/fenix/settings/SyncPreferenceView.kt index f88973c02..8f71e2d0b 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SyncPreferenceView.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SyncPreferenceView.kt @@ -30,7 +30,6 @@ import mozilla.components.service.fxa.manager.SyncEnginesStorage * @param onReconnectClicked A callback executed when the [syncPreference] is clicked with a * preference status of "Reconnect". */ -@Suppress("LongParameterList") class SyncPreferenceView( private val syncPreference: SyncPreference, lifecycleOwner: LifecycleOwner, diff --git a/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineShortcuts.kt b/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineShortcuts.kt index 29b751197..46ca337e4 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineShortcuts.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineShortcuts.kt @@ -60,7 +60,6 @@ import org.mozilla.fenix.theme.FirefoxTheme * @param onDeleteEngineClicked Invoked when the user clicks on the delete item of the three dot menu. * @param onAddEngineClicked Invoked when the user clicks on the add search engine button. */ -@Suppress("LongParameterList") @Composable fun SearchEngineShortcuts( categoryTitle: String, @@ -125,7 +124,7 @@ private fun Title(title: String) { } } -@Suppress("LongParameterList", "LongMethod") +@Suppress("LongMethod") @Composable private fun SearchItem( engine: SearchEngine, diff --git a/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettings.kt b/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettings.kt index fe31ee967..2f07d9541 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettings.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettings.kt @@ -68,7 +68,6 @@ import org.mozilla.fenix.wallpapers.Wallpaper */ @SuppressLint("UnusedMaterialScaffoldPaddingParameter") @Composable -@Suppress("LongParameterList") fun WallpaperSettings( wallpaperGroups: Map>, defaultWallpaper: Wallpaper, @@ -193,7 +192,6 @@ private fun WallpaperGroupHeading( * @param numColumns The number of columns that will occupy the grid. */ @Composable -@Suppress("LongParameterList") fun WallpaperThumbnails( wallpapers: List, defaultWallpaper: Wallpaper, @@ -244,7 +242,6 @@ fun WallpaperThumbnails( * @param onSelect Action to take when a new wallpaper is selected. */ @Composable -@Suppress("LongParameterList") private fun WallpaperThumbnailItem( wallpaper: Wallpaper, defaultWallpaper: Wallpaper, diff --git a/app/src/main/java/org/mozilla/fenix/shopping/ui/ReviewQualityCheckContextualOnboarding.kt b/app/src/main/java/org/mozilla/fenix/shopping/ui/ReviewQualityCheckContextualOnboarding.kt index 249a3cfbe..e5c53777b 100644 --- a/app/src/main/java/org/mozilla/fenix/shopping/ui/ReviewQualityCheckContextualOnboarding.kt +++ b/app/src/main/java/org/mozilla/fenix/shopping/ui/ReviewQualityCheckContextualOnboarding.kt @@ -48,7 +48,7 @@ private const val MAX_SUPPORTED_VENDORS_PER_TLD = 3 * @param onPrimaryButtonClick Invoked when a user clicks on the primary button. * @param onSecondaryButtonClick Invoked when a user clicks on the secondary button. */ -@Suppress("LongParameterList", "LongMethod") +@Suppress("LongMethod") @Composable fun ReviewQualityCheckContextualOnboarding( productVendors: List, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/NavigationInteractor.kt b/app/src/main/java/org/mozilla/fenix/tabstray/NavigationInteractor.kt index f30b42584..9d31caeaa 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/NavigationInteractor.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/NavigationInteractor.kt @@ -61,7 +61,7 @@ interface NavigationInteractor { /** * A default implementation of [NavigationInteractor]. */ -@Suppress("LongParameterList", "TooManyFunctions") +@Suppress("TooManyFunctions") class DefaultNavigationInteractor( private val browserStore: BrowserStore, private val navController: NavController, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTray.kt b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTray.kt index 79f3dded0..cff61af7d 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTray.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTray.kt @@ -481,7 +481,7 @@ private fun TabsTrayAutoCloseBannerPreview() { ) } -@Suppress("LongMethod", "LongParameterList") +@Suppress("LongMethod") @Composable private fun TabsTrayPreviewRoot( displayTabsInGrid: Boolean = true, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt index 53450efc7..2779acc4f 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayBanner.kt @@ -184,7 +184,7 @@ fun TabsTrayBanner( } } -@Suppress("LongMethod", "LongParameterList") +@Suppress("LongMethod") @Composable private fun SingleSelectBanner( menuItems: List, @@ -381,7 +381,7 @@ private fun NormalTabsTabIcon(normalTabCount: Int) { * @param onSaveToCollectionsClick Invoked when the user clicks on the save to collection button. * @param onShareSelectedTabs Invoked when the user clicks on the share button. */ -@Suppress("LongMethod", "LongParameterList") +@Suppress("LongMethod") @Composable private fun MultiSelectBanner( menuItems: List, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt index dc02b56fa..7c923bf86 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt @@ -639,7 +639,6 @@ class TabsTrayFragment : AppCompatDialogFragment() { } @VisibleForTesting - @Suppress("LongParameterList") internal fun setupPager( context: Context, lifecycleOwner: LifecycleOwner, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/TrayPagerAdapter.kt b/app/src/main/java/org/mozilla/fenix/tabstray/TrayPagerAdapter.kt index cc97a53cd..c871166b6 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/TrayPagerAdapter.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/TrayPagerAdapter.kt @@ -20,7 +20,6 @@ import org.mozilla.fenix.tabstray.viewholders.NormalBrowserPageViewHolder import org.mozilla.fenix.tabstray.viewholders.PrivateBrowserPageViewHolder import org.mozilla.fenix.tabstray.viewholders.SyncedTabsPageViewHolder -@Suppress("LongParameterList") class TrayPagerAdapter( internal val context: Context, internal val lifecycleOwner: LifecycleOwner, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolder.kt b/app/src/main/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolder.kt index de5a5cd07..8cb5d51d5 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolder.kt @@ -54,7 +54,6 @@ import org.mozilla.fenix.tabstray.ext.toDisplayTitle * @property featureName [String] representing the name of the feature displaying tabs. Used in telemetry reporting. * @param store [BrowserStore] containing the complete state of the browser and methods to update that. */ -@Suppress("LongParameterList") abstract class AbstractBrowserTabViewHolder( itemView: View, private val imageLoader: ImageLoader, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabViewHolder.kt b/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabViewHolder.kt index e8c96761e..698080617 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabViewHolder.kt @@ -34,7 +34,6 @@ import org.mozilla.fenix.GleanMetrics.TabsTray as TabsTrayMetrics * @param interactor [InactiveTabsInteractor] used to respond to interactions with the inactive tabs header * and the auto close dialog. */ -@Suppress("LongParameterList") class InactiveTabViewHolder( composeView: ComposeView, lifecycleOwner: LifecycleOwner, diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAdapter.kt b/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAdapter.kt index 30ce40632..ebcbf0984 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAdapter.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAdapter.kt @@ -20,7 +20,6 @@ import org.mozilla.fenix.tabstray.TabsTrayStore * and the auto close dialog. * @property featureName [String] representing the name of the inactive tabs feature for telemetry reporting. */ -@Suppress("LongParameterList") class InactiveTabsAdapter( private val lifecycleOwner: LifecycleOwner, private val tabsTrayStore: TabsTrayStore, diff --git a/app/src/main/java/org/mozilla/fenix/translations/TranslationsBottomSheet.kt b/app/src/main/java/org/mozilla/fenix/translations/TranslationsBottomSheet.kt index f248524cb..c598677aa 100644 --- a/app/src/main/java/org/mozilla/fenix/translations/TranslationsBottomSheet.kt +++ b/app/src/main/java/org/mozilla/fenix/translations/TranslationsBottomSheet.kt @@ -126,7 +126,6 @@ internal fun TranslationsOptionsAnimation( } } -@Suppress("LongParameterList") @Composable internal fun TranslationsDialog( learnMoreUrl: String, diff --git a/app/src/main/java/org/mozilla/fenix/translations/preferences/downloadlanguages/DownloadLanguageFileDialog.kt b/app/src/main/java/org/mozilla/fenix/translations/preferences/downloadlanguages/DownloadLanguageFileDialog.kt index 7485031f5..45c847b57 100644 --- a/app/src/main/java/org/mozilla/fenix/translations/preferences/downloadlanguages/DownloadLanguageFileDialog.kt +++ b/app/src/main/java/org/mozilla/fenix/translations/preferences/downloadlanguages/DownloadLanguageFileDialog.kt @@ -44,7 +44,6 @@ import org.mozilla.fenix.theme.FirefoxTheme * @param onConfirmDownload Invoked when the user click on the "Download" dialog button. * @param onCancel Invoked when the user clicks on the "Cancel" dialog button. */ -@Suppress("LongParameterList") @Composable fun DownloadLanguageFileDialog( fileSize: Long, diff --git a/app/src/main/java/org/mozilla/fenix/utils/Undo.kt b/app/src/main/java/org/mozilla/fenix/utils/Undo.kt index d5b792976..9cb2531b6 100644 --- a/app/src/main/java/org/mozilla/fenix/utils/Undo.kt +++ b/app/src/main/java/org/mozilla/fenix/utils/Undo.kt @@ -44,7 +44,6 @@ fun Context.getUndoDelay(): Long { * @param elevation The elevation of the [FenixSnackbar]. * @param paddedForBottomToolbar Whether or not [FenixSnackbar] is displayed with the bottom toolbar. */ -@Suppress("LongParameterList") fun CoroutineScope.allowUndo( view: View, message: String, diff --git a/app/src/main/java/org/mozilla/fenix/wallpapers/WallpaperOnboarding.kt b/app/src/main/java/org/mozilla/fenix/wallpapers/WallpaperOnboarding.kt index 916d34e55..7ddc56edb 100644 --- a/app/src/main/java/org/mozilla/fenix/wallpapers/WallpaperOnboarding.kt +++ b/app/src/main/java/org/mozilla/fenix/wallpapers/WallpaperOnboarding.kt @@ -40,8 +40,6 @@ import org.mozilla.fenix.theme.FirefoxTheme * @param onExploreMoreButtonClicked Callback for when the bottom text button is clicked. * @param onSelectWallpaper Callback for when a new wallpaper is selected. */ - -@Suppress("LongParameterList") @ExperimentalMaterialApi @Composable fun WallpaperOnboarding( diff --git a/app/src/test/java/org/mozilla/fenix/components/TrackingProtectionPolicyFactoryTest.kt b/app/src/test/java/org/mozilla/fenix/components/TrackingProtectionPolicyFactoryTest.kt index 322580025..53983d987 100644 --- a/app/src/test/java/org/mozilla/fenix/components/TrackingProtectionPolicyFactoryTest.kt +++ b/app/src/test/java/org/mozilla/fenix/components/TrackingProtectionPolicyFactoryTest.kt @@ -675,7 +675,6 @@ class TrackingProtectionPolicyFactoryTest { every { shouldUseTrackingProtection } returns useTrackingProtection } - @Suppress("LongParameterList") private fun settingsForCustom( shouldBlockCookiesInCustom: Boolean, blockTrackingContentInCustom: String = all, // ["private", "all"] diff --git a/app/src/test/java/org/mozilla/fenix/components/toolbar/DefaultBrowserToolbarMenuControllerTest.kt b/app/src/test/java/org/mozilla/fenix/components/toolbar/DefaultBrowserToolbarMenuControllerTest.kt index b2aea0412..8b1cac0f6 100644 --- a/app/src/test/java/org/mozilla/fenix/components/toolbar/DefaultBrowserToolbarMenuControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/components/toolbar/DefaultBrowserToolbarMenuControllerTest.kt @@ -843,7 +843,6 @@ class DefaultBrowserToolbarMenuControllerTest { } } - @Suppress("LongParameterList") private fun createController( scope: CoroutineScope, store: BrowserStore, diff --git a/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkControllerTest.kt b/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkControllerTest.kt index f7daf4549..47262dc0f 100644 --- a/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkControllerTest.kt @@ -527,7 +527,6 @@ class BookmarkControllerTest { } } - @Suppress("LongParameterList") private fun createController( loadBookmarkNode: suspend (String, Boolean) -> BookmarkNode? = { _, _ -> null }, showSnackbar: (String) -> Unit = { _ -> }, diff --git a/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt b/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt index 9f46daa0f..bcdcae3f5 100644 --- a/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt @@ -310,7 +310,6 @@ class HistoryMetadataGroupControllerTest { ) } - @Suppress("LongParameterList") private fun createController( deleteSnackbar: ( items: Set, diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt index bab29f1d7..b224566f1 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt @@ -163,7 +163,6 @@ class NavigationInteractorTest { verify(exactly = 1) { navController.navigate(any()) } } - @Suppress("LongParameterList") private fun createInteractor( browserStore: BrowserStore = store, dismissTabTray: () -> Unit = { }, diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolderTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolderTest.kt index 755bb304e..5fab000b1 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolderTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/browser/AbstractBrowserTabViewHolderTest.kt @@ -159,7 +159,6 @@ class AbstractBrowserTabViewHolderTest { verify { mediaSessionController.pause() } } - @Suppress("LongParameterList") class TestTabTrayViewHolder( itemView: View, imageLoader: ImageLoader,