[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - The inactiveTabsCount probe reports actualInactiveTabs number

pull/600/head
Mugurell 3 years ago committed by mergify[bot]
parent f40c19f406
commit b95234f9d5

@ -1258,6 +1258,7 @@ metrics:
lifetime: application
description: |
How many inactive tabs does the user have.
Value will be 0 if the feature is disabled.
send_in_pings:
- metrics
bugs:

@ -80,8 +80,8 @@ import org.mozilla.fenix.components.Core
import org.mozilla.fenix.components.metrics.Event
import org.mozilla.fenix.components.metrics.MozillaProductDetector
import org.mozilla.fenix.components.toolbar.ToolbarPosition
import org.mozilla.fenix.ext.actualInactiveTabs
import org.mozilla.fenix.perf.MarkersActivityLifecycleCallbacks
import org.mozilla.fenix.ext.potentialInactiveTabs
import org.mozilla.fenix.utils.Settings
/**
@ -628,7 +628,7 @@ open class FenixApplication : LocaleAwareApplication(), Provider {
tabViewSetting.set(settings.getTabViewPingString())
closeTabSetting.set(settings.getTabTimeoutPingString())
inactiveTabsCount.set(browserStore.state.potentialInactiveTabs.size.toLong())
inactiveTabsCount.set(browserStore.state.actualInactiveTabs(settings).size.toLong())
val installSourcePackage = if (SDK_INT >= Build.VERSION_CODES.R) {
packageManager.getInstallSourceInfo(packageName).installingPackageName

@ -32,8 +32,8 @@ import org.mozilla.fenix.GleanMetrics.Preferences
import org.mozilla.fenix.GleanMetrics.SearchDefaultEngine
import org.mozilla.fenix.components.metrics.MozillaProductDetector
import org.mozilla.fenix.components.toolbar.ToolbarPosition
import org.mozilla.fenix.ext.actualInactiveTabs
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.ext.potentialInactiveTabs
import org.mozilla.fenix.utils.BrowsersCache
import org.mozilla.fenix.utils.Settings
import org.robolectric.annotation.Config
@ -143,8 +143,8 @@ class FenixApplicationTest {
every { settings.searchTermTabGroupsAreEnabled } returns true
every { application.reportHomeScreenMetrics(settings) } just Runs
every { settings.inactiveTabsAreEnabled } returns true
mockkStatic("org.mozilla.fenix.tabstray.ext.TabSelectorsKt") {
every { browserStore.state.potentialInactiveTabs } returns listOf(mockk(), mockk())
mockkStatic("org.mozilla.fenix.ext.BrowserStateKt") {
every { browserStore.state.actualInactiveTabs(any()) } returns listOf(mockk(), mockk())
application.setStartupMetrics(browserStore, settings, browsersCache, mozillaProductDetector)

Loading…
Cancel
Save