From a92d52af807c8b046227dd117f3439a6ad79a726 Mon Sep 17 00:00:00 2001 From: DreVla Date: Fri, 2 Feb 2024 12:22:02 +0200 Subject: [PATCH] Bug 1840969 - Add title for homepage default browser info card Title for the card info to set Firefox as default browser was missing, "Switch your default browser" is the title now, to match with iOS. --- app/messaging-evergreen-messages.fml.yaml | 1 + app/src/main/java/org/mozilla/fenix/compose/MessageCard.kt | 4 ++-- app/src/main/res/values/strings.xml | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/messaging-evergreen-messages.fml.yaml b/app/messaging-evergreen-messages.fml.yaml index a09773ac5..36e7d2b15 100644 --- a/app/messaging-evergreen-messages.fml.yaml +++ b/app/messaging-evergreen-messages.fml.yaml @@ -25,6 +25,7 @@ import: - value: messages: default-browser: + title: default_browser_experiment_card_title text: default_browser_experiment_card_text surface: homescreen action: "MAKE_DEFAULT_BROWSER" diff --git a/app/src/main/java/org/mozilla/fenix/compose/MessageCard.kt b/app/src/main/java/org/mozilla/fenix/compose/MessageCard.kt index d5a6cc1d8..d3669470c 100644 --- a/app/src/main/java/org/mozilla/fenix/compose/MessageCard.kt +++ b/app/src/main/java/org/mozilla/fenix/compose/MessageCard.kt @@ -208,7 +208,7 @@ private fun MessageCardPreview() { ) { MessageCard( messageText = stringResource(id = R.string.default_browser_experiment_card_text), - titleText = stringResource(id = R.string.bookmark_empty_title_error), + titleText = stringResource(id = R.string.default_browser_experiment_card_title), onClick = {}, onCloseButtonClick = {}, ) @@ -245,7 +245,7 @@ private fun MessageCardWithButtonLabelPreview() { ) { MessageCard( messageText = stringResource(id = R.string.default_browser_experiment_card_text), - titleText = stringResource(id = R.string.bookmark_empty_title_error), + titleText = stringResource(id = R.string.default_browser_experiment_card_title), buttonText = stringResource(id = R.string.preferences_set_as_default_browser), onClick = {}, onCloseButtonClick = {}, diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index ad5d9588a..119fb2d1d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -2089,6 +2089,9 @@ %s search + + Switch your default browser + Set links from websites, emails, and messages to open automatically in Firefox.