Bug 1853413 - Remove references to an old naming of the shopper footer as "byline"

fenix/119.0
Noah Bond 9 months ago committed by mergify[bot]
parent 2316c8a96d
commit a358384b2a

@ -53,7 +53,7 @@ import org.mozilla.fenix.theme.FirefoxTheme
* @param onProductRecommendationsEnabledStateChange Invoked when the user changes the product
* recommendations toggle state.
* @param onReviewGradeLearnMoreClick Invoked when the user clicks to learn more about review grades.
* @param onBylineLinkClick Invoked when the user clicks on the byline link.
* @param onFooterLinkClick Invoked when the user clicks on the footer link.
* @param modifier The modifier to be applied to the Composable.
*/
@Composable
@ -65,7 +65,7 @@ fun ProductAnalysis(
onReanalyzeClick: () -> Unit,
onProductRecommendationsEnabledStateChange: (Boolean) -> Unit,
onReviewGradeLearnMoreClick: (String) -> Unit,
onBylineLinkClick: (String) -> Unit,
onFooterLinkClick: (String) -> Unit,
modifier: Modifier = Modifier,
) {
Column(
@ -126,7 +126,7 @@ fun ProductAnalysis(
)
ReviewQualityCheckFooter(
onLinkClick = onBylineLinkClick,
onLinkClick = onFooterLinkClick,
)
}
}
@ -417,7 +417,7 @@ private fun ProductAnalysisPreview() {
productRecommendationsEnabled.value = it
},
onReviewGradeLearnMoreClick = {},
onBylineLinkClick = {},
onFooterLinkClick = {},
)
}
}

@ -24,7 +24,7 @@ import org.mozilla.fenix.theme.FirefoxTheme
* @param onOptOutClick Invoked when the user opts out of the review quality check feature.
* @param onProductRecommendationsEnabledStateChange Invoked when the user changes the product
* recommendations toggle state.
* @param onBylineLinkClick Invoked when the user clicks on the byline link.
* @param onFooterLinkClick Invoked when the user clicks on the footer link.
* @param modifier Modifier to apply to the layout.
*/
@Composable
@ -33,7 +33,7 @@ fun ProductAnalysisError(
onReviewGradeLearnMoreClick: (String) -> Unit,
onOptOutClick: () -> Unit,
onProductRecommendationsEnabledStateChange: (Boolean) -> Unit,
onBylineLinkClick: (String) -> Unit,
onFooterLinkClick: (String) -> Unit,
modifier: Modifier = Modifier,
) {
Column(
@ -54,7 +54,7 @@ fun ProductAnalysisError(
)
ReviewQualityCheckFooter(
onLinkClick = onBylineLinkClick,
onLinkClick = onFooterLinkClick,
)
}
}
@ -74,7 +74,7 @@ private fun ProductAnalysisErrorPreview() {
onReviewGradeLearnMoreClick = {},
onOptOutClick = {},
onProductRecommendationsEnabledStateChange = {},
onBylineLinkClick = {},
onFooterLinkClick = {},
modifier = Modifier.fillMaxWidth(),
)
}

@ -69,7 +69,7 @@ fun ReviewQualityCheckBottomSheet(
),
)
},
onBylineLinkClick = { url ->
onFooterLinkClick = { url ->
store.dispatch(
ReviewQualityCheckAction.OpenLink(
ReviewQualityCheckState.LinkType.ExternalLink(url),
@ -98,7 +98,7 @@ private fun ProductReview(
onReanalyzeClick: () -> Unit,
onProductRecommendationsEnabledStateChange: (Boolean) -> Unit,
onReviewGradeLearnMoreClick: (String) -> Unit,
onBylineLinkClick: (String) -> Unit,
onFooterLinkClick: (String) -> Unit,
) {
Crossfade(
targetState = state.productReviewState,
@ -113,7 +113,7 @@ private fun ProductReview(
onReanalyzeClick = onReanalyzeClick,
onProductRecommendationsEnabledStateChange = onProductRecommendationsEnabledStateChange,
onReviewGradeLearnMoreClick = onReviewGradeLearnMoreClick,
onBylineLinkClick = onBylineLinkClick,
onFooterLinkClick = onFooterLinkClick,
)
}
@ -123,7 +123,7 @@ private fun ProductReview(
onReviewGradeLearnMoreClick = onReviewGradeLearnMoreClick,
onOptOutClick = onOptOutClick,
onProductRecommendationsEnabledStateChange = onProductRecommendationsEnabledStateChange,
onBylineLinkClick = onBylineLinkClick,
onFooterLinkClick = onFooterLinkClick,
modifier = Modifier.fillMaxWidth(),
)
}

Loading…
Cancel
Save