Bug 1840471 - Release Menu Printing out of Nightly

This bug removes the menu printing feature flag from the browser menu
and share bar to allow menu printing to ride the trains to release.
fenix/118.0
Olivia Hall 10 months ago committed by mergify[bot]
parent 640b377723
commit 939ee63f8d

@ -27,7 +27,6 @@ import androidx.test.uiautomator.Until
import org.hamcrest.Matchers.allOf
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.R
import org.mozilla.fenix.helpers.Constants.LONG_CLICK_DURATION
import org.mozilla.fenix.helpers.Constants.RETRY_COUNT
@ -112,7 +111,7 @@ class ThreeDotMenuMainRobot {
assertItemContainingTextExists(
settingsButton(),
)
if (FeatureFlags.print && FxNimbus.features.print.value().browserPrintEnabled) {
if (FxNimbus.features.print.value().browserPrintEnabled) {
assertItemContainingTextExists(printContentButton)
}
assertItemWithDescriptionExists(

@ -63,11 +63,6 @@ object FeatureFlags {
*/
const val unifiedSearchSettings = true
/**
* Enables printing from the share and primary menu.
*/
val print = Config.channel.isNightlyOrDebug
/**
* Enables the lib-state HistoryFragment refactor
*/

@ -35,7 +35,6 @@ import mozilla.components.feature.webcompat.reporter.WebCompatReporterFeature
import mozilla.components.lib.state.ext.flowScoped
import mozilla.components.support.ktx.android.content.getColorFromAttr
import mozilla.components.support.ktx.kotlinx.coroutines.flow.ifAnyChanged
import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.R
import org.mozilla.fenix.components.accounts.FenixAccountManager
import org.mozilla.fenix.ext.components
@ -393,7 +392,7 @@ open class DefaultToolbarMenu(
installToHomescreen.apply { visible = ::canInstall },
if (shouldShowTopSites) addRemoveTopSitesItem else null,
saveToCollectionItem,
if (FeatureFlags.print && FxNimbus.features.print.value().browserPrintEnabled) printPageItem else null,
if (FxNimbus.features.print.value().browserPrintEnabled) printPageItem else null,
BrowserMenuDivider(),
settingsItem,
if (shouldDeleteDataOnQuit) deleteDataOnQuit else null,

@ -23,7 +23,6 @@ import mozilla.components.concept.base.crash.Breadcrumb
import mozilla.components.concept.engine.prompt.PromptRequest
import mozilla.components.feature.accounts.push.SendTabUseCases
import mozilla.components.feature.share.RecentAppsStorage
import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.R
import org.mozilla.fenix.components.FenixSnackbar
import org.mozilla.fenix.databinding.FragmentShareBinding
@ -134,7 +133,7 @@ class ShareFragment : AppCompatDialogFragment() {
}
FxNimbus.features.print.recordExposure()
if (FeatureFlags.print && FxNimbus.features.print.value().sharePrintEnabled) {
if (FxNimbus.features.print.value().sharePrintEnabled) {
binding.print.setContent {
FirefoxTheme(theme = Theme.getTheme(allowPrivateTheme = false)) {
PrintItem {

Loading…
Cancel
Save