From 8d1afeec607b8c99a9f27f6072a71665434fc706 Mon Sep 17 00:00:00 2001 From: William Durand Date: Fri, 13 Oct 2023 10:16:17 +0200 Subject: [PATCH] Bug 1858925 - Fix `homepageUrl` field on the `Addon` class --- .../mozilla/fenix/addons/AddonDetailsBindingDelegate.kt | 8 ++++---- .../fenix/addons/AddonDetailsBindingDelegateTest.kt | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegate.kt b/app/src/main/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegate.kt index 7628c0d1b..56dca0f2a 100644 --- a/app/src/main/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegate.kt +++ b/app/src/main/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegate.kt @@ -53,7 +53,7 @@ class AddonDetailsBindingDelegate( bindAuthor(addon) bindVersion(addon) bindLastUpdated(addon) - bindWebsite(addon) + bindHomepage(addon) bindRating(addon) } @@ -75,15 +75,15 @@ class AddonDetailsBindingDelegate( } } - private fun bindWebsite(addon: Addon) { - if (addon.siteUrl.isBlank()) { + private fun bindHomepage(addon: Addon) { + if (addon.homepageUrl.isBlank()) { binding.homePageLabel.isVisible = false binding.homePageDivider.isVisible = false return } binding.homePageLabel.setOnClickListener { - interactor.openWebsite(addon.siteUrl.toUri()) + interactor.openWebsite(addon.homepageUrl.toUri()) } } diff --git a/app/src/test/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegateTest.kt b/app/src/test/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegateTest.kt index 437b95443..d27c02ebf 100644 --- a/app/src/test/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegateTest.kt +++ b/app/src/test/java/org/mozilla/fenix/addons/AddonDetailsBindingDelegateTest.kt @@ -87,10 +87,10 @@ class AddonDetailsBindingDelegateTest { } @Test - fun `bind addons website`() { + fun `bind addons homepage`() { detailsBindingDelegate.bind( baseAddon.copy( - siteUrl = "https://mozilla.org", + homepageUrl = "https://mozilla.org", ), ) @@ -187,7 +187,7 @@ class AddonDetailsBindingDelegateTest { @Test fun `bind without a home page`() { - detailsBindingDelegate.bind(baseAddon.copy(siteUrl = "")) + detailsBindingDelegate.bind(baseAddon.copy(homepageUrl = "")) assertFalse(binding.homePageLabel.isVisible) assertFalse(binding.homePageDivider.isVisible)