From 8a5020123fd77f4cf2dba82817e45ccef20f74fb Mon Sep 17 00:00:00 2001 From: Gabriel Luong Date: Mon, 3 Jan 2022 12:00:11 -0500 Subject: [PATCH] For #23017 - Ignore ExtraTranslation in our lint-baseline --- app/lint-baseline.xml | 4554 ++--------------------------------------- app/lint.xml | 2 +- 2 files changed, 182 insertions(+), 4374 deletions(-) diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml index 6873fa848..49ee30ea6 100644 --- a/app/lint-baseline.xml +++ b/app/lint-baseline.xml @@ -741,4452 +741,239 @@ errorLine2=" ~~~~"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + line="842" + column="55"/> + id="InflateParams" + message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout's root element)" + errorLine1=" val dialogView = LayoutInflater.from(context).inflate(R.layout.mp_migration_dialog, null)" + errorLine2=" ~~~~"> + file="src/main/java/org/mozilla/fenix/components/tips/providers/MasterPasswordTipProvider.kt" + line="75" + column="93"/> + id="InflateParams" + message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout's root element)" + errorLine1=" LayoutInflater.from(context).inflate(R.layout.mp_migration_done_dialog, null)" + errorLine2=" ~~~~"> + file="src/main/java/org/mozilla/fenix/components/tips/providers/MasterPasswordTipProvider.kt" + line="164" + column="85"/> + id="InflateParams" + message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout's root element)" + errorLine1=" LayoutInflater.from(context).inflate(R.layout.mp_migration_done_dialog, null)" + errorLine2=" ~~~~"> + file="src/main/java/org/mozilla/fenix/components/tips/providers/MasterPasswordTipProvider.kt" + line="221" + column="85"/> + id="InflateParams" + message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout's root element)" + errorLine1=" LayoutInflater.from(it).inflate(R.layout.top_sites_rename_dialog, null)" + errorLine2=" ~~~~"> + file="src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt" + line="323" + column="83"/> + id="InflateParams" + message="Avoid passing `null` as the view root (needed to resolve layout parameters on the inflated layout's root element)" + errorLine1=" val dialogView = LayoutInflater.from(context).inflate(R.layout.amo_collection_override_dialog, null)" + errorLine2=" ~~~~"> + file="src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt" + line="355" + column="112"/> + id="InvalidLicenseFormat" + message="The license comment must be followed by a newline character" + errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */" + errorLine2=" ~"> + file="src/main/java/org/mozilla/fenix/components/FxaServer.kt" + line="3" + column="62"/> + id="MissingLicense" + message="The file must start with a comment containing the license" + errorLine1="package org.mozilla.fenix.utils;" + errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/utils/OnWifiChanged.java" + line="1" + column="1"/> + id="UseSwitchCompatOrMaterialCode" + message="Use `SwitchCompat` from AppCompat or `SwitchMaterial` from Material library" + errorLine1=" private var switchView: Switch? = null" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/settings/DefaultBrowserPreference.kt" + line="20" + column="5"/> + id="UseSwitchCompatOrMaterialXml" + message="Use `SwitchCompat` from AppCompat or `SwitchMaterial` from Material library" + errorLine1="<Switch xmlns:android="http://schemas.android.com/apk/res/android"" + errorLine2="^"> + file="src/main/res/layout/preference_default_browser.xml" + line="6" + column="1"/> + id="VectorRaster" + message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more" + errorLine1=" android:width="1889dp"" + errorLine2=" ~~~~~~"> + file="src/main/res/drawable/ic_etp_artwork.xml" + line="7" + column="20"/> + id="VisibleForTests" + message="This method should only be accessed from tests or within private scope" + errorLine1=" isInPrimaryState = { getCurrentTab()?.content?.canGoBack ?: false }," + errorLine2=" ~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt" + line="99" + column="38"/> + id="VisibleForTests" + message="This method should only be accessed from tests or within private scope" + errorLine1=" isInPrimaryState = { getCurrentTab()?.content?.canGoForward ?: false }," + errorLine2=" ~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt" + line="121" + column="38"/> + id="VisibleForTests" + message="This method should only be accessed from tests or within private scope" + errorLine1=" getCurrentTab()?.content?.loading == false" + errorLine2=" ~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt" + line="144" + column="21"/> + id="VisibleForTests" + message="This method should only be accessed from tests or within private scope" + errorLine1=" if (getCurrentTab()?.content?.loading == true) {" + errorLine2=" ~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt" + line="158" + column="25"/> + id="VisibleForTests" + message="This method should only be accessed from tests or within private scope" + errorLine1=" selected = getCurrentTab()?.let {" + errorLine2=" ~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt" + line="186" + column="28"/> + id="VisibleForTests" + message="This method should only be accessed from tests or within private scope" + errorLine1=" getCurrentTab()?.let { tab ->" + errorLine2=" ~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt" + line="276" + column="9"/> + id="VisibleForTests" + message="This method should only be accessed from tests or within private scope" + errorLine1=" tabsAction.updateCount(tabCount)" + errorLine2=" ~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt" + line="138" + column="20"/> + id="ComposableNaming" + message="Composable functions with a return type should start with a lowercase letter" + errorLine1="fun EagerFlingBehavior(" + errorLine2=" ~~~~~~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/compose/LazyListEagerFlingBehavior.kt" + line="21" + column="5"/> + id="UseCompatLoadingForDrawables" + message="Use `AppCompatResources.getDrawable()`" + errorLine1=" display.setUrlBackground(getDrawable(R.drawable.search_url_background))" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt" + line="89" + column="46"/> + id="Typos" + message=""internett" is usually capitalized as "Internett"" + errorLine1=" <string name="private_browsing_placeholder_description_2">%1$s fjerner søk- og nettleserhistorikken fra private nettlesingsfaner når du lukker dem eller avslutter appen. Selv om dette ikke gjør deg anonym for nettsteder eller internett-leverandøren din, vil det gjøre det lettere" + errorLine2=" ^"> + file="src/main/res/values-nb-rNO/strings.xml" + line="71" + column="231"/> + id="Typos" + message="Repeated word "zaman" in message: possible typo" + errorLine1=" <string name="studies_description">Firefox zaman zaman araştırmalar yükleyip çalıştırabilir.</string>" + errorLine2=" ^"> + file="src/main/res/values-tr/strings.xml" + line="737" + column="48"/> @@ -5416,7 +1203,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -5900,7 +1687,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -5911,7 +1698,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -5922,7 +1709,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -5933,7 +1720,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -6026,6 +1813,13 @@ file="src/main/res/drawable/ic_jd.png"/> + + + + @@ -6040,6 +1834,20 @@ file="src/main/res/drawable/ic_tc.png"/> + + + + + + + + @@ -6090,7 +1898,7 @@ errorLine2=" ^"> @@ -6101,7 +1909,7 @@ errorLine2=" ^"> @@ -6112,7 +1920,7 @@ errorLine2=" ^"> @@ -6123,7 +1931,7 @@ errorLine2=" ^"> @@ -6134,7 +1942,7 @@ errorLine2=" ^"> diff --git a/app/lint.xml b/app/lint.xml index c490f2dbe..f90a3647d 100644 --- a/app/lint.xml +++ b/app/lint.xml @@ -14,7 +14,7 @@ - +