Closes #9928 - Updates private browsing text description

fennec/production
ekager 4 years ago committed by Mihai Adrian
parent 5d51c4f059
commit 66d9a24b28

@ -552,10 +552,10 @@ private fun assertPrivateSessionHeader() =
onView(allOf(withText("Private tabs")))
.check(matches(withEffectiveVisibility(Visibility.VISIBLE)))
const val PRIVATE_SESSION_MESSAGE = "Firefox Preview clears your search and browsing history " +
"when you quit the app or close all private tabs. While this doesnt make you anonymous to websites or " +
"your internet service provider, it makes it easier to keep what you do online private from anyone else " +
"who uses this device."
const val PRIVATE_SESSION_MESSAGE =
"Firefox Preview clears your search and browsing history from private tabs when you close them or quit the app." +
" While this doesn't make you anonymous to websites or your internet service provider," +
" it makes it easier to keep what you do online from anyone else who uses this device."
private fun assertPrivateSessionMessage(visible: Boolean) =
onView(allOf(withText(PRIVATE_SESSION_MESSAGE)))

@ -22,7 +22,7 @@ class PrivateBrowsingDescriptionViewHolder(
val resources = view.context.resources
val appName = resources.getString(R.string.app_name)
view.private_session_description.text = resources.getString(
R.string.private_browsing_placeholder_description, appName
R.string.private_browsing_placeholder_description_2, appName
)
val commonMythsText = view.private_session_common_myths.text.toString()
val textWithLink = SpannableString(commonMythsText).apply {

@ -19,7 +19,7 @@
android:lineSpacingExtra="6dp"
android:gravity="center_vertical"
android:scrollHorizontally="false"
tools:text="@string/private_browsing_placeholder_description"
tools:text="@string/private_browsing_placeholder_description_2"
android:textColor="?primaryText"
android:textSize="14sp" />
<TextView

@ -28,9 +28,8 @@
<string name="private_browsing_title">Youre in a private session</string>
<!-- Explanation for private browsing displayed to users on home view when they first enable private mode
The first parameter is the name of the app defined in app_name (for example: Fenix) -->
<string name="private_browsing_placeholder_description">
%1$s clears your search and browsing history when you quit the app or close all private tabs. While this doesnt make you anonymous to websites or your internet service provider, it makes it
easier to keep what you do online private from anyone else who uses this device.
<string name="private_browsing_placeholder_description_2">
%1$s clears your search and browsing history from private tabs when you close them or quit the app. While this doesn\'t make you anonymous to websites or your internet service provider, it makes it easier to keep what you do online from anyone else who uses this device.
</string>
<string name="private_browsing_common_myths">
Common myths about private browsing

Loading…
Cancel
Save