From 6516eff5c8fbd9aa01c8ab80ad61715f439a6b0a Mon Sep 17 00:00:00 2001
From: mcarare <mihai.carare.dev@gmail.com>
Date: Fri, 9 Oct 2020 13:58:15 +0300
Subject: [PATCH] For #13831: Adjust buttons dimensions to improve a11y.

Margins were also adjusted to maintain relative placements.
---
 .../main/res/layout/fragment_login_detail.xml | 22 +++++++++----------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/app/src/main/res/layout/fragment_login_detail.xml b/app/src/main/res/layout/fragment_login_detail.xml
index 685ca8f15..cfb6bb0da 100644
--- a/app/src/main/res/layout/fragment_login_detail.xml
+++ b/app/src/main/res/layout/fragment_login_detail.xml
@@ -9,8 +9,7 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:layout_marginStart="73dp"
-    android:layout_marginTop="12dp"
-    android:layout_marginEnd="12dp">
+    android:layout_marginTop="12dp">
 
     <TextView
         android:id="@+id/webAddressHeader"
@@ -38,7 +37,7 @@
         android:paddingBottom="@dimen/saved_logins_detail_menu_vertical_padding"
         android:textColor="?primaryText"
         android:textSize="16sp"
-        app:layout_constraintEnd_toEndOf="@id/webAddressHeader"
+        app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="@id/webAddressHeader"
         app:layout_constraintTop_toBottomOf="@id/webAddressHeader"
         app:layout_constraintVertical_chainStyle="packed"
@@ -46,8 +45,8 @@
 
     <ImageButton
         android:id="@+id/openWebAddress"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_width="48dp"
+        android:layout_height="48dp"
         android:background="?android:attr/selectableItemBackgroundBorderless"
         android:contentDescription="@string/saved_login_open_site"
         app:layout_constraintBottom_toBottomOf="@id/webAddressText"
@@ -91,8 +90,8 @@
 
     <ImageButton
         android:id="@+id/copyUsername"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_width="48dp"
+        android:layout_height="48dp"
         android:background="?android:attr/selectableItemBackgroundBorderless"
         android:contentDescription="@string/saved_login_copy_username"
         app:layout_constraintBottom_toBottomOf="@id/usernameText"
@@ -138,9 +137,8 @@
 
     <ImageButton
         android:id="@+id/revealPasswordButton"
-        android:layout_width="20dp"
-        android:layout_height="20dp"
-        android:layout_marginEnd="36dp"
+        android:layout_width="48dp"
+        android:layout_height="48dp"
         android:background="@null"
         android:contentDescription="@string/saved_login_reveal_password"
         app:layout_constraintBottom_toBottomOf="@id/passwordText"
@@ -151,8 +149,8 @@
 
     <ImageButton
         android:id="@+id/copyPassword"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_width="48dp"
+        android:layout_height="48dp"
         android:background="?android:attr/selectableItemBackgroundBorderless"
         android:contentDescription="@string/saved_logins_copy_password"
         app:layout_constraintBottom_toBottomOf="@id/passwordText"