Bug 1881703 - Notify app store of mode change from TabsTray

fenix/125.0
rahulsainani 3 months ago committed by mergify[bot]
parent b742795cd3
commit 62dd5fe59e

@ -536,7 +536,9 @@ class DefaultTabsTrayController(
selected.isEmpty() && tabsTrayStore.state.mode.isSelect().not() -> {
TabsTray.openedExistingTab.record(TabsTray.OpenedExistingTabExtra(source ?: "unknown"))
tabsUseCases.selectTab(tab.id)
browsingModeManager.mode = BrowsingMode.fromBoolean(tab.content.private)
val mode = BrowsingMode.fromBoolean(tab.content.private)
browsingModeManager.mode = mode
appStore.dispatch(AppAction.ModeChange(mode))
handleNavigateToBrowser()
}
tab.id in selected.map { it.id } -> handleTabUnselected(tab)

@ -63,6 +63,7 @@ import org.mozilla.fenix.collections.CollectionsDialog
import org.mozilla.fenix.collections.show
import org.mozilla.fenix.components.AppStore
import org.mozilla.fenix.components.TabCollectionStorage
import org.mozilla.fenix.components.appstate.AppAction
import org.mozilla.fenix.components.bookmarks.BookmarksUseCase
import org.mozilla.fenix.ext.maxActiveTime
import org.mozilla.fenix.ext.potentialInactiveTabs
@ -958,6 +959,7 @@ class DefaultTabsTrayControllerTest {
assertEquals(privateTab.id, browserStore.state.selectedTabId)
assertEquals(true, browsingModeManager.mode.isPrivate)
verify { appStore.dispatch(AppAction.ModeChange(BrowsingMode.Private)) }
controller.handleTabDeletion("privateTab")
browserStore.dispatch(TabListAction.SelectTabAction(normalTab.id)).joinBlocking()
@ -965,6 +967,7 @@ class DefaultTabsTrayControllerTest {
assertEquals(normalTab.id, browserStore.state.selectedTabId)
assertEquals(false, browsingModeManager.mode.isPrivate)
verify { appStore.dispatch(AppAction.ModeChange(BrowsingMode.Normal)) }
} finally {
unmockkStatic("mozilla.components.browser.state.selector.SelectorsKt")
}

Loading…
Cancel
Save