Bug 1861058 - Translations UI Make navigating from one bottom sheet to another more smooth.

fenix/121.0
iorgamgabriel 7 months ago committed by mergify[bot]
parent d0c7c9f92c
commit 6289aef354

@ -4,8 +4,6 @@
package org.mozilla.fenix.translations
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.defaultMinSize
@ -15,15 +13,12 @@ import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.Icon
import androidx.compose.material.IconButton
import androidx.compose.material.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.input.nestedscroll.nestedScroll
import androidx.compose.ui.platform.rememberNestedScrollInteropConnection
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.heading
@ -46,63 +41,59 @@ import java.util.Locale
* @param aboutTranslationClicked Invoked when the user clicks on the "About Translation" button.
*/
@Composable
fun TranslationOptionsDialogBottomSheet(
fun TranslationOptionsDialog(
translationOptionsList: List<TranslationSwitchItem>,
onBackClicked: () -> Unit,
onTranslationSettingsClicked: () -> Unit,
aboutTranslationClicked: () -> Unit,
) {
Column(
modifier = Modifier
.background(
color = FirefoxTheme.colors.layer2,
shape = RoundedCornerShape(topStart = 8.dp, topEnd = 8.dp),
)
.nestedScroll(rememberNestedScrollInteropConnection()),
) {
TranslationOptionsDialogHeader(onBackClicked)
LazyColumn {
items(translationOptionsList) { item: TranslationSwitchItem ->
SwitchWithLabel(
checked = item.isChecked,
onCheckedChange = item.onStateChange,
label = item.textLabel,
modifier = Modifier
.padding(start = 72.dp, end = 16.dp),
)
TranslationOptionsDialogHeader(onBackClicked)
if (item.hasDivider) {
Divider(Modifier.padding(top = 4.dp, bottom = 4.dp))
}
}
LazyColumn {
items(translationOptionsList) { item: TranslationSwitchItem ->
TranslationOptions(translationSwitchItem = item)
}
item {
TextListItem(
label = stringResource(id = R.string.translation_option_bottom_sheet_translation_settings),
modifier = Modifier
.fillMaxWidth()
.padding(start = 56.dp),
onClick = { onTranslationSettingsClicked() },
)
}
item {
TextListItem(
label = stringResource(id = R.string.translation_option_bottom_sheet_translation_settings),
modifier = Modifier
.fillMaxWidth()
.padding(start = 56.dp),
onClick = { onTranslationSettingsClicked() },
)
}
item {
TextListItem(
label = stringResource(
id = R.string.translation_option_bottom_sheet_about_translations,
formatArgs = arrayOf(stringResource(R.string.app_name)),
),
modifier = Modifier
.fillMaxWidth()
.padding(start = 56.dp),
onClick = { aboutTranslationClicked() },
)
}
item {
TextListItem(
label = stringResource(
id = R.string.translation_option_bottom_sheet_about_translations,
formatArgs = arrayOf(stringResource(R.string.app_name)),
),
modifier = Modifier
.fillMaxWidth()
.padding(start = 56.dp),
onClick = { aboutTranslationClicked() },
)
}
}
}
@Composable
private fun TranslationOptions(translationSwitchItem: TranslationSwitchItem) {
SwitchWithLabel(
checked = translationSwitchItem.isChecked,
onCheckedChange = translationSwitchItem.onStateChange,
label = translationSwitchItem.textLabel,
modifier = Modifier
.padding(start = 72.dp, end = 16.dp),
)
if (translationSwitchItem.hasDivider) {
Divider(Modifier.padding(top = 4.dp, bottom = 4.dp))
}
}
@Composable
private fun TranslationOptionsDialogHeader(
onBackClicked: () -> Unit,
@ -189,7 +180,7 @@ fun getTranslationOptionsList(): List<TranslationSwitchItem> {
@LightDarkPreview
private fun TranslationSettingsPreview() {
FirefoxTheme {
TranslationOptionsDialogBottomSheet(
TranslationOptionsDialog(
translationOptionsList = getTranslationOptionsList(),
onBackClicked = {},
onTranslationSettingsClicked = {},

@ -1,63 +0,0 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
package org.mozilla.fenix.translations
import android.app.Dialog
import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.compose.ui.platform.ComposeView
import androidx.navigation.fragment.findNavController
import com.google.android.material.bottomsheet.BottomSheetBehavior
import com.google.android.material.bottomsheet.BottomSheetDialogFragment
import org.mozilla.fenix.R
import org.mozilla.fenix.browser.BrowserFragmentDirections
import org.mozilla.fenix.theme.FirefoxTheme
/**
* A bottom sheet fragment displaying the Firefox Translation Options dialog.
*/
class TranslationOptionsDialogFragment : BottomSheetDialogFragment() {
private var behavior: BottomSheetBehavior<View>? = null
override fun onCreateDialog(savedInstanceState: Bundle?): Dialog =
super.onCreateDialog(savedInstanceState).apply {
setOnShowListener {
val bottomSheet =
findViewById<View?>(R.id.design_bottom_sheet)
bottomSheet?.setBackgroundResource(android.R.color.transparent)
behavior = BottomSheetBehavior.from(bottomSheet)
}
}
override fun onCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?,
): View = ComposeView(requireContext()).apply {
setContent {
FirefoxTheme {
TranslationOptionsDialogBottomSheet(
translationOptionsList = getTranslationOptionsList(),
onBackClicked = {
findNavController().popBackStack()
findNavController().navigate(
BrowserFragmentDirections.actionBrowserFragmentToTranslationsDialogFragment(),
)
},
onTranslationSettingsClicked = {
findNavController().popBackStack()
findNavController().navigate(
TranslationSettingsFragmentDirections.actionGlobalToTranslationSettingsFragment(),
)
},
aboutTranslationClicked = {},
)
}
}
}
}

@ -43,9 +43,10 @@ class TranslationSettingsFragment : Fragment(), UserInteractionHandler {
}
override fun onBackPressed(): Boolean {
findNavController().popBackStack()
findNavController().navigate(
TranslationsDialogFragmentDirections.actionGlobalToTranslationOptionsDialogFragment(),
TranslationSettingsFragmentDirections.actionTranslationSettingsFragmentToTranslationsDialogFragment(
TranslationsDialogAccessPoint.TranslationsOptions,
),
)
return true
}

@ -0,0 +1,146 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
package org.mozilla.fenix.translations
import androidx.compose.animation.AnimatedVisibility
import androidx.compose.animation.AnimatedVisibilityScope
import androidx.compose.animation.core.FastOutSlowInEasing
import androidx.compose.animation.core.tween
import androidx.compose.animation.expandIn
import androidx.compose.animation.fadeIn
import androidx.compose.animation.slideInHorizontally
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.Divider
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.input.nestedscroll.nestedScroll
import androidx.compose.ui.platform.rememberNestedScrollInteropConnection
import androidx.compose.ui.unit.Density
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.IntSize
import androidx.compose.ui.unit.dp
import org.mozilla.fenix.theme.FirefoxTheme
private const val BOTTOM_SHEET_HANDLE_WIDTH_PERCENT = 0.1f
@Composable
internal fun TranslationDialogBottomSheet(content: @Composable () -> Unit) {
Column(
modifier = Modifier
.background(
color = FirefoxTheme.colors.layer2,
shape = RoundedCornerShape(topStart = 8.dp, topEnd = 8.dp),
)
.nestedScroll(rememberNestedScrollInteropConnection()),
) {
Divider(
Modifier
.padding(top = 16.dp)
.fillMaxWidth(BOTTOM_SHEET_HANDLE_WIDTH_PERCENT)
.align(alignment = Alignment.CenterHorizontally),
color = FirefoxTheme.colors.borderInverted,
thickness = 3.dp,
)
content()
}
}
@Composable
internal fun TranslationsAnimation(
translationsVisibility: Boolean,
density: Density,
translationsOptionsHeightDp: Dp,
content: @Composable AnimatedVisibilityScope.() -> Unit,
) {
AnimatedVisibility(
visible = translationsVisibility,
enter = expandIn(
animationSpec = tween(
easing = FastOutSlowInEasing,
),
initialSize = {
with(density) {
IntSize(
0,
translationsOptionsHeightDp.roundToPx(),
)
}
},
) + fadeIn(
animationSpec = tween(
easing = FastOutSlowInEasing,
),
) + slideInHorizontally(
animationSpec = tween(
easing = FastOutSlowInEasing,
),
),
) {
content()
}
}
@Composable
internal fun TranslationsOptionsAnimation(
translationsVisibility: Boolean,
density: Density,
translationsHeightDp: Dp,
translationsWidthDp: Dp,
content: @Composable AnimatedVisibilityScope.() -> Unit,
) {
AnimatedVisibility(
visible = translationsVisibility,
enter = expandIn(
animationSpec = tween(
easing = FastOutSlowInEasing,
),
initialSize = {
with(density) {
IntSize(
0,
translationsHeightDp.roundToPx(),
)
}
},
) + fadeIn(
animationSpec = tween(
easing = FastOutSlowInEasing,
),
) + slideInHorizontally(
initialOffsetX = { with(density) { translationsWidthDp.roundToPx() } },
animationSpec = tween(
easing = FastOutSlowInEasing,
),
),
) {
content()
}
}
@Composable
internal fun TranslationsDialog(onSettingClicked: () -> Unit) {
TranslationsDialogBottomSheet(
onSettingClicked = onSettingClicked,
)
}
@Composable
internal fun TranslationsOptionsDialog(
onBackClicked: () -> Unit,
onTranslationSettingsClicked: () -> Unit,
) {
TranslationOptionsDialog(
translationOptionsList = getTranslationOptionsList(),
onBackClicked = onBackClicked,
onTranslationSettingsClicked = onTranslationSettingsClicked,
aboutTranslationClicked = {},
)
}

@ -4,7 +4,6 @@
package org.mozilla.fenix.translations
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
@ -14,7 +13,6 @@ import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material.Divider
import androidx.compose.material.Icon
import androidx.compose.material.IconButton
@ -41,10 +39,6 @@ import org.mozilla.fenix.theme.FirefoxTheme
fun TranslationsDialogBottomSheet(onSettingClicked: () -> Unit) {
Column(
modifier = Modifier
.background(
color = FirefoxTheme.colors.layer2,
shape = RoundedCornerShape(topStart = 8.dp, topEnd = 8.dp),
)
.padding(16.dp),
) {
TranslationsDialogHeader(onSettingClicked)

@ -9,25 +9,42 @@ import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.compose.foundation.layout.Column
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.layout.onGloballyPositioned
import androidx.compose.ui.platform.ComposeView
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.unit.dp
import androidx.navigation.fragment.findNavController
import androidx.navigation.fragment.navArgs
import com.google.android.material.bottomsheet.BottomSheetBehavior
import com.google.android.material.bottomsheet.BottomSheetDialogFragment
import org.mozilla.fenix.R
import org.mozilla.fenix.theme.FirefoxTheme
/**
* The enum is to know what bottom sheet to open.
*/
enum class TranslationsDialogAccessPoint {
Translations, TranslationsOptions,
}
/**
* A bottom sheet fragment displaying the Firefox Translation dialog.
*/
class TranslationsDialogFragment : BottomSheetDialogFragment() {
private var behavior: BottomSheetBehavior<View>? = null
private val args by navArgs<TranslationsDialogFragmentArgs>()
override fun onCreateDialog(savedInstanceState: Bundle?): Dialog =
super.onCreateDialog(savedInstanceState).apply {
setOnShowListener {
val bottomSheet =
findViewById<View?>(R.id.design_bottom_sheet)
val bottomSheet = findViewById<View?>(R.id.design_bottom_sheet)
bottomSheet?.setBackgroundResource(android.R.color.transparent)
behavior = BottomSheetBehavior.from(bottomSheet)
}
@ -40,14 +57,79 @@ class TranslationsDialogFragment : BottomSheetDialogFragment() {
): View = ComposeView(requireContext()).apply {
setContent {
FirefoxTheme {
TranslationsDialogBottomSheet(
onSettingClicked = {
findNavController().popBackStack()
findNavController().navigate(
TranslationsDialogFragmentDirections.actionGlobalToTranslationOptionsDialogFragment(),
)
},
)
var translationsVisibility by remember {
mutableStateOf(args.translationsDialogAccessPoint == TranslationsDialogAccessPoint.Translations)
}
var translationsHeightDp by remember {
mutableStateOf(0.dp)
}
var translationsOptionsHeightDp by remember {
mutableStateOf(0.dp)
}
var translationsWidthDp by remember {
mutableStateOf(0.dp)
}
val density = LocalDensity.current
TranslationDialogBottomSheet {
TranslationsAnimation(
translationsVisibility = translationsVisibility,
density = density,
translationsOptionsHeightDp = translationsOptionsHeightDp,
) {
if (translationsVisibility) {
Column(
modifier = Modifier.onGloballyPositioned { coordinates ->
translationsHeightDp = with(density) {
coordinates.size.height.toDp()
}
translationsWidthDp = with(density) {
coordinates.size.width.toDp()
}
},
) {
TranslationsDialog(
onSettingClicked = {
translationsVisibility = false
},
)
}
}
}
TranslationsOptionsAnimation(
translationsVisibility = !translationsVisibility,
density = density,
translationsHeightDp = translationsHeightDp,
translationsWidthDp = translationsWidthDp,
) {
if (!translationsVisibility) {
Column(
modifier = Modifier.onGloballyPositioned { coordinates ->
translationsOptionsHeightDp = with(density) {
coordinates.size.height.toDp()
}
},
) {
TranslationsOptionsDialog(
onBackClicked = {
translationsVisibility = true
},
onTranslationSettingsClicked = {
findNavController().navigate(
TranslationsDialogFragmentDirections
.actionTranslationsDialogFragmentToTranslationSettingsFragment(),
)
},
)
}
}
}
}
}
}
}

@ -164,12 +164,6 @@
<action
android:id="@+id/action_global_tabSettingsFragment"
app:destination="@id/tabsSettingsFragment" />
<action
android:id="@+id/action_global_to_translationOptionsDialogFragment"
app:destination="@id/translationOptionsDialogFragment" />
<action
android:id="@+id/action_global_to_translationSettingsFragment"
app:destination="@id/translationSettingsFragment" />
<dialog
android:id="@+id/tabsTrayFragment"
android:name="org.mozilla.fenix.tabstray.TabsTrayFragment">
@ -309,7 +303,7 @@
app:destination="@id/reviewQualityCheckFragment" />
<action
android:id="@+id/action_browserFragment_to_translationsDialogFragment"
app:destination="@id/translationsDialogFragment" />
app:destination="@id/translations_graph" />
</fragment>
<fragment
@ -424,18 +418,6 @@
android:id="@+id/reviewQualityCheckFragment"
android:name="org.mozilla.fenix.shopping.ReviewQualityCheckFragment"/>
<dialog
android:id="@+id/translationsDialogFragment"
android:name="org.mozilla.fenix.translations.TranslationsDialogFragment"/>
<dialog
android:id="@+id/translationOptionsDialogFragment"
android:name="org.mozilla.fenix.translations.TranslationOptionsDialogFragment" />
<fragment
android:id="@+id/translationSettingsFragment"
android:name="org.mozilla.fenix.translations.TranslationSettingsFragment" />
<fragment
android:id="@+id/savedLoginsAuthFragment"
android:name="org.mozilla.fenix.settings.logins.fragment.SavedLoginsAuthFragment"
@ -1438,4 +1420,29 @@
app:popUpToInclusive="true" />
</fragment>
</navigation>
<navigation
android:id="@+id/translations_graph"
app:startDestination="@id/translationsDialogFragment">
<dialog
android:id="@+id/translationsDialogFragment"
android:name="org.mozilla.fenix.translations.TranslationsDialogFragment">
<argument
android:name="translationsDialogAccessPoint"
android:defaultValue="Translations"
app:argType="org.mozilla.fenix.translations.TranslationsDialogAccessPoint" />
<action
android:id="@+id/action_translationsDialogFragment_to_translationSettingsFragment"
app:destination="@id/translationSettingsFragment" />
</dialog>
<fragment
android:id="@+id/translationSettingsFragment"
android:name="org.mozilla.fenix.translations.TranslationSettingsFragment">
<action
android:id="@+id/action_translationSettingsFragment_to_translationsDialogFragment"
app:destination="@id/translationsDialogFragment"
app:popUpTo="@id/translationSettingsFragment"
app:popUpToInclusive="true" />
</fragment>
</navigation>
</navigation>

Loading…
Cancel
Save