diff --git a/app/src/main/java/org/mozilla/fenix/settings/account/AccountSettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/account/AccountSettingsFragment.kt index a1820a408..b6f76d8bd 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/account/AccountSettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/account/AccountSettingsFragment.kt @@ -162,7 +162,7 @@ class AccountSettingsFragment : PreferenceFragmentCompat() { // Make sure out sync engine checkboxes are up-to-date and disabled if currently syncing updateSyncEngineStates() - setCwtsDisabledWhileSyncing(accountManager.isSyncActive()) + setDisabledWhileSyncing(accountManager.isSyncActive()) val historyNameKey = getPreferenceKey(R.string.pref_key_sync_history) findPreference(historyNameKey)?.apply { @@ -317,10 +317,14 @@ class AccountSettingsFragment : PreferenceFragmentCompat() { } } - private fun setCwtsDisabledWhileSyncing(isSyncing: Boolean) { + private fun setDisabledWhileSyncing(isSyncing: Boolean) { findPreference( getPreferenceKey(R.string.preferences_sync_category) )?.isEnabled = !isSyncing + + findPreference( + getPreferenceKey(R.string.pref_key_sync_device_name) + )?.isEnabled = !isSyncing } private val syncStatusObserver = object : SyncStatusObserver { @@ -330,7 +334,7 @@ class AccountSettingsFragment : PreferenceFragmentCompat() { view?.announceForAccessibility(getString(R.string.sync_syncing_in_progress)) pref?.title = getString(R.string.sync_syncing_in_progress) pref?.isEnabled = false - setCwtsDisabledWhileSyncing(true) + setDisabledWhileSyncing(true) } } @@ -347,7 +351,7 @@ class AccountSettingsFragment : PreferenceFragmentCompat() { } // Make sure out sync engine checkboxes are up-to-date. updateSyncEngineStates() - setCwtsDisabledWhileSyncing(false) + setDisabledWhileSyncing(false) } } diff --git a/app/src/main/res/xml/account_settings_preferences.xml b/app/src/main/res/xml/account_settings_preferences.xml index a83baa30a..dfd617235 100644 --- a/app/src/main/res/xml/account_settings_preferences.xml +++ b/app/src/main/res/xml/account_settings_preferences.xml @@ -1,12 +1,17 @@ - - + + + + @@ -29,10 +34,5 @@ android:defaultValue="true" android:key="@string/pref_key_sync_logins" android:title="@string/preferences_sync_logins" /> - - -