From 4fe1fb8f4afcac1059f4eafa2f968e528f1e8a6e Mon Sep 17 00:00:00 2001 From: Elise Richards Date: Thu, 16 Jul 2020 13:38:07 -0500 Subject: [PATCH] No issue: Delete unnecessary to-dos (#12603) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Hakkı Kaan Çalışkan --- app/src/main/java/org/mozilla/fenix/ext/String.kt | 1 - .../java/org/mozilla/fenix/lintrules/ButtonStyleXmlDetector.kt | 1 - 2 files changed, 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/ext/String.kt b/app/src/main/java/org/mozilla/fenix/ext/String.kt index f0a90094a..56744f49e 100644 --- a/app/src/main/java/org/mozilla/fenix/ext/String.kt +++ b/app/src/main/java/org/mozilla/fenix/ext/String.kt @@ -126,7 +126,6 @@ suspend fun String.toRoundedDrawable(context: Context, client: Client) = bitmapF } suspend fun bitmapForUrl(url: String, client: Client): Bitmap? = withContext(Dispatchers.IO) { - // TODO cache this image, see https://github.com/mozilla-mobile/fenix/issues/9531 // Code below will cache it in Gecko's cache, which ensures that as long as we've fetched it once, // we will be able to display this avatar as long as the cache isn't purged (e.g. via 'clear user data'). val body = try { diff --git a/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ButtonStyleXmlDetector.kt b/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ButtonStyleXmlDetector.kt index ceac3222d..c96f3a8e9 100644 --- a/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ButtonStyleXmlDetector.kt +++ b/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ButtonStyleXmlDetector.kt @@ -22,7 +22,6 @@ class ButtonStyleXmlDetector : ResourceXmlDetector() { companion object { const val SCHEMA = "http://schemas.android.com/apk/res-auto" - // TODO: const val ERROR_MESSAGE = "All buttons must have a style, try using NeutralButton or similar."