From 4b94215f599dcacb34d7935689dada6baa0bc276 Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Wed, 21 Oct 2020 10:34:10 -0700 Subject: [PATCH] For #15707: remove super.visitElement for ConstraintLayout lint. It caused a test to fail because super.visitElement asserted false because it expected to be overriden. It was correctly overridden - we were just still calling through to super anyway. --- .../org/mozilla/fenix/lintrules/ConstraintLayoutPerfDetector.kt | 2 -- 1 file changed, 2 deletions(-) diff --git a/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ConstraintLayoutPerfDetector.kt b/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ConstraintLayoutPerfDetector.kt index 7ae61bce5..78e4fd1e8 100644 --- a/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ConstraintLayoutPerfDetector.kt +++ b/mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/ConstraintLayoutPerfDetector.kt @@ -168,8 +168,6 @@ class ConstraintLayoutPerfDetector : ResourceXmlDetector() { } override fun visitElement(context: XmlContext, element: Element) { - super.visitElement(context, element) - // This scope is unideal: if the root element is a ConstraintLayout and is suppressed, all // ConstraintLayout children will also be suppressed. If more ConstraintLayout children are // added, the root ConstraintLayout will suppress them too. Ideally, we'd want a suppression