Bug 1870362 - Add underline to each link in the add-on details view

fenix/124.1.0
William Durand 3 months ago committed by mergify[bot]
parent 5ad9a003a6
commit 499e533ac2

@ -22,6 +22,7 @@ import mozilla.components.feature.addons.ui.updatedAtDate
import mozilla.components.support.ktx.android.content.getColorFromAttr
import org.mozilla.fenix.R
import org.mozilla.fenix.databinding.FragmentAddOnDetailsBinding
import org.mozilla.fenix.ext.addUnderline
import java.text.DateFormat
import java.text.NumberFormat
import java.util.Locale
@ -70,6 +71,7 @@ class AddonDetailsBindingDelegate(
if (addon.ratingUrl.isNotBlank()) {
binding.reviewCount.setTextColor(binding.root.context.getColorFromAttr(R.attr.textAccent))
binding.reviewCount.addUnderline()
binding.reviewCount.setOnClickListener {
interactor.openWebsite(addon.ratingUrl.toUri())
}
@ -85,6 +87,7 @@ class AddonDetailsBindingDelegate(
return
}
binding.homePageLabel.addUnderline()
binding.homePageLabel.setOnClickListener {
interactor.openWebsite(addon.homepageUrl.toUri())
}
@ -134,6 +137,7 @@ class AddonDetailsBindingDelegate(
if (author.url.isNotBlank()) {
binding.authorText.setTextColor(binding.root.context.getColorFromAttr(R.attr.textAccent))
binding.authorText.addUnderline()
binding.authorText.setOnClickListener {
interactor.openWebsite(author.url.toUri())
}
@ -181,6 +185,7 @@ class AddonDetailsBindingDelegate(
return
}
binding.detailUrl.addUnderline()
binding.detailUrl.setOnClickListener {
interactor.openWebsite(addon.detailUrl.toUri())
}

@ -85,7 +85,7 @@ class AddonDetailsBindingDelegateTest {
ratingUrl = "https://example.org/",
),
)
assertEquals("100", binding.reviewCount.text)
assertEquals("100", binding.reviewCount.text.toString())
binding.reviewCount.performClick()
@ -163,7 +163,7 @@ class AddonDetailsBindingDelegateTest {
baseAddon.copy(author = Addon.Author(name = "Sarah Jane", url = "https://example.org/")),
)
assertEquals("Sarah Jane", binding.authorText.text)
assertEquals("Sarah Jane", binding.authorText.text.toString())
assertEquals(testContext.getColorFromAttr(R.attr.textAccent), binding.authorText.currentTextColor)
binding.authorText.performClick()

Loading…
Cancel
Save