Issue #25805: Always anchored unified search menu to the toolbar icon

pull/543/head
Roger Yang 2 years ago committed by mergify[bot]
parent 3445717ad6
commit 46d73673ec

@ -724,12 +724,7 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
}
} + searchSelectorMenu.menuItems()
if (requireContext().settings().shouldUseBottomToolbar) {
searchSelectorMenu.menuController.submitList(searchEngineList.reversed())
} else {
searchSelectorMenu.menuController.submitList(searchEngineList)
}
searchSelectorMenu.menuController.submitList(searchEngineList)
toolbarView.view.invalidateActions()
}

@ -52,7 +52,7 @@ class SearchSelectorToolbarAction(
}
UnifiedSearch.searchMenuTapped.record(NoExtras())
menu.menuController.show(anchor = it, orientation = orientation)
menu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
}
setBackgroundResource(

@ -86,7 +86,7 @@ class SearchSelectorToolbarActionTest {
assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
verify {
menu.menuController.show(view, Orientation.DOWN)
menu.menuController.show(view, Orientation.DOWN, true)
}
every { settings.shouldUseBottomToolbar } returns true
@ -94,7 +94,7 @@ class SearchSelectorToolbarActionTest {
assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
verify {
menu.menuController.show(view, Orientation.UP)
menu.menuController.show(view, Orientation.UP, true)
}
}

Loading…
Cancel
Save