From 451093fd9e17d6d2977633cd4c09a2950a260038 Mon Sep 17 00:00:00 2001 From: Emily Kager Date: Tue, 16 Jul 2019 14:10:33 -0700 Subject: [PATCH] Closes #2560 - Updates Private Browsing explanation string --- .../viewholders/PrivateBrowsingDescriptionViewHolder.kt | 2 +- app/src/main/res/layout/private_browsing_description.xml | 2 +- app/src/main/res/values/strings.xml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/PrivateBrowsingDescriptionViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/PrivateBrowsingDescriptionViewHolder.kt index 8571c46c9..1579475e5 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/PrivateBrowsingDescriptionViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/PrivateBrowsingDescriptionViewHolder.kt @@ -26,7 +26,7 @@ class PrivateBrowsingDescriptionViewHolder( val resources = view.context.resources // Format the description text to include a hyperlink val appName = resources.getString(R.string.app_name) - view.private_session_description.text = resources.getString(R.string.private_browsing_explanation, appName) + view.private_session_description.text = resources.getString(R.string.private_browsing_placeholder, appName) val descriptionText = String .format(view.private_session_description.text.toString(), System.getProperty("line.separator")) val linkStartIndex = descriptionText.indexOf("\n\n") + 2 diff --git a/app/src/main/res/layout/private_browsing_description.xml b/app/src/main/res/layout/private_browsing_description.xml index 76f1fe6f5..bab1c1db6 100644 --- a/app/src/main/res/layout/private_browsing_description.xml +++ b/app/src/main/res/layout/private_browsing_description.xml @@ -23,7 +23,7 @@ android:ellipsize="none" android:gravity="center_vertical" android:scrollHorizontally="false" - tools:text="@string/private_browsing_explanation" + tools:text="@string/private_browsing_placeholder" android:textColor="?primaryText" android:textSize="14sp" /> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 52f449454..c016e96ce 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -21,8 +21,8 @@ You’re in a private session - %1$s clears your search and browsing history when you close your private - session. While this doesn’t make you anonymous to websites or your internet service provider, it makes it + + %1$s clears your search and browsing history when you quit the app or close all private tabs. While this doesn’t make you anonymous to websites or your internet service provider, it makes it easier to keep what you do online private from anyone else who uses this device.\n\nCommon myths about private browsing