Merge pull request #3617 from mozilla-mobile/mergify/bp/releases_v118/pr-1576

Bug 1807127 - Update Sync Device name after refreshing fxa devices (backport #1576)
fenix/118.0
Pascal Chevrel 8 months ago committed by GitHub
commit 44fbe57b15

@ -367,6 +367,7 @@ class AccountSettingsFragment : PreferenceFragmentCompat() {
?.deviceConstellation()
?.setDeviceName(newDeviceName, it)
}
accountSettingsStore.dispatch(AccountSettingsFragmentAction.UpdateDeviceName(newDeviceName))
}
return true
}

@ -46,7 +46,8 @@ class AccountSettingsInteractor(
}
// Our "change the device name on the server" operation may fail.
// Currently, we disregard this failure and pretend we succeeded.
// At the same time, when user changes the device name, we immediately update the UI to display the new name.
// At the same time, when user changes the device name,
// we immediately update the UI to display the new name.
// So, in case of a network (or other) failure when talking to the server,
// we'll have a discrepancy - the UI will reflect new value, but actually the value never changed.
// So, when user presses "sync now", we'll fetch the old value, and reset the UI.

Loading…
Cancel
Save