From 44de36e30283796bdf01e05ec68e6b2421e1c443 Mon Sep 17 00:00:00 2001 From: mcarare Date: Thu, 15 Apr 2021 11:52:50 +0300 Subject: [PATCH] No issue: Rename Event for naming consistency. (cherry picked from commit 8b3a878062d01cd9dc1578fcb46b6844961963b1) --- app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt | 2 +- .../org/mozilla/fenix/components/metrics/GleanMetricsService.kt | 2 +- .../fenix/home/sessioncontrol/SessionControlController.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt index ff79f9bdd..aff2f88d8 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt @@ -226,7 +226,7 @@ sealed class Event { object OpenedTabSuggestionClicked : Event() // Set default browser experiment metrics - object SetDefaultBrowserClicked : Event() + object SetDefaultBrowserNewTabClicked : Event() object CloseExperimentCardClicked : Event() object ToolbarMenuShown : Event() object SetDefaultBrowserToolbarMenuClicked : Event() diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt index edb2a1a7d..7eb8ee48b 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt @@ -833,7 +833,7 @@ private val Event.wrapper: EventWrapper<*>? is Event.CloseExperimentCardClicked -> EventWrapper( { SetDefaultNewtabExperiment.closeExperimentCardClicked.record(it) } ) - is Event.SetDefaultBrowserClicked -> EventWrapper( + is Event.SetDefaultBrowserNewTabClicked -> EventWrapper( { SetDefaultNewtabExperiment.setDefaultBrowserClicked.record(it) } ) is Event.SetDefaultBrowserSettingsScreenClicked -> EventWrapper( diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt index 62cd02563..318dcb163 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt @@ -567,7 +567,7 @@ class DefaultSessionControlController( override fun handleSetDefaultBrowser() { settings.userDismissedExperimentCard = true - metrics.track(Event.SetDefaultBrowserClicked) + metrics.track(Event.SetDefaultBrowserNewTabClicked) activity.openSetDefaultBrowserOption() }