Bug 1876610 - Minor Translations UI Adjustments

This patch completes a few minor translations UI adjustments. Including
updating mock data on the "never translate these sites" page and the
"language settings" page.

Additionally, adds a content description on the toolbar for the
translation icon.
fenix/124.1.0
ohall-m 4 months ago committed by mergify[bot]
parent 7a909e3f79
commit 3470a4e951

@ -230,7 +230,7 @@ class BrowserFragment : BaseBrowserFragment(), UserInteractionHandler {
context,
R.drawable.mozac_ic_translate_24,
)!!,
contentDescription = "",
contentDescription = context.getString(R.string.browser_toolbar_translate),
contentDescriptionSelected = "",
visible = {
translationsAvailable || context.settings().enableTranslations

@ -78,25 +78,25 @@ internal fun getAutomaticTranslationListPreferences(): List<AutomaticTranslation
return mutableListOf<AutomaticTranslationItemPreference>().apply {
add(
AutomaticTranslationItemPreference(
displayName = Locale.CANADA.displayName,
displayName = Locale.CANADA.displayLanguage,
automaticTranslationOptionPreference = AutomaticTranslationOptionPreference.AlwaysTranslate(),
),
)
add(
AutomaticTranslationItemPreference(
displayName = Locale.FRANCE.displayName,
displayName = Locale.FRANCE.displayLanguage,
automaticTranslationOptionPreference = AutomaticTranslationOptionPreference.OfferToTranslate(),
),
)
add(
AutomaticTranslationItemPreference(
displayName = Locale.GERMANY.displayName,
displayName = Locale.GERMANY.displayLanguage,
automaticTranslationOptionPreference = AutomaticTranslationOptionPreference.NeverTranslate(),
),
)
add(
AutomaticTranslationItemPreference(
displayName = Locale.CHINA.displayName,
displayName = Locale.CHINA.displayLanguage,
automaticTranslationOptionPreference = AutomaticTranslationOptionPreference.AlwaysTranslate(),
),
)

@ -82,12 +82,7 @@ internal fun getNeverTranslateListItemsPreference(): List<NeverTranslateSiteList
return mutableListOf<NeverTranslateSiteListItemPreference>().apply {
add(
NeverTranslateSiteListItemPreference(
websiteUrl = "expedia.ca",
),
)
add(
NeverTranslateSiteListItemPreference(
websiteUrl = "wikipedia.com",
websiteUrl = "mozilla.org",
),
)
}

@ -233,12 +233,16 @@
<string name="browser_menu_edit">Edit</string>
<!-- Button shown on the home page that opens the Customize home settings -->
<string name="browser_menu_customize_home_1">Customize homepage</string>
<!-- Browser Toolbar -->
<!-- Content description for the Home screen button on the browser toolbar -->
<string name="browser_toolbar_home">Home screen</string>
<!-- Content description (not visible, for screen readers etc.): Erase button: Erase the browsing
history and go back to the home screen. -->
<string name="browser_toolbar_erase">Erase browsing history</string>
<!-- Content description for the translate page toolbar button that opens the translations dialog when no translation has occurred. -->
<string name="browser_toolbar_translate">Translate page</string>
<!-- Locale Settings Fragment -->
<!-- Content description for tick mark on selected language -->
<string name="a11y_selected_locale_content_description">Selected language</string>

Loading…
Cancel
Save