From 346f85868e28a8b117a73eabc2bbc8af97426af6 Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Wed, 11 Nov 2020 15:19:54 -0800 Subject: [PATCH] No issue: perf code owner all /perf/ src dir. Our previous strategy was to code owner all the specific files we should own but that's fragile and unreasonable. This is simpler. We expect there will still be edge cases that live outside these directories (e.g. *Application*kt). --- .github/CODEOWNERS | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 371451c41..6f6711ea8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -42,7 +42,12 @@ # Therefore, we make the Perfomance team code owners of this file. /.github/CODEOWNERS @mozilla-mobile/Performance -/app/src/*/java/org/mozilla/fenix/perf/** @mozilla-mobile/Performance +# Own /perf/ src directories which typically includes perf code architecture +# or code that monitors for perf regressions. This is our main way to own code +# because it's simpler and less fragile than listing many specific files to own. +/**/src/**/perf/** @mozilla-mobile/Performance + +# Possible regressions throughout the app *.pro @mozilla-mobile/Performance *proguard* @mozilla-mobile/Performance