Synced Tabs: make sure to stop 'loading' when we encounter an error

4 years ago · 31248b835c
parent c265a7089a
commit 31248b835c
1 changed files with 3 additions and 0 deletions
--- a/app/src/main/java/org/mozilla/fenix/sync/SyncedTabsLayout.kt
+++ b/app/src/main/java/org/mozilla/fenix/sync/SyncedTabsLayout.kt
@ -34,6 +34,9 @@ class SyncedTabsLayout @JvmOverloads constructor(
    }

    override fun onError(error: SyncedTabsView.ErrorType) {
+        // We may still be displaying a "loading" spinner, hide it.
+        stopLoading()
+
        val stringResId = when (error) {
            SyncedTabsView.ErrorType.MULTIPLE_DEVICES_UNAVAILABLE -> R.string.synced_tabs_connect_another_device
            SyncedTabsView.ErrorType.SYNC_ENGINE_UNAVAILABLE -> R.string.synced_tabs_enable_tab_syncing