Bug 1841582 - Opening link from shortcuts should display the page.

app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt

@@ -394,11 +394,10 @@ class DefaultSessionControlController(
             if (settings.openNextTabInDesktopMode) {
                 activity.handleRequestDesktopMode(tabId)
             }
-            activity.openToBrowser(BrowserDirection.FromHome)
         } else {
             selectTabUseCase.invoke(existingTabForUrl.id)
-            navController.navigate(R.id.browserFragment)
         }
+        navController.navigate(R.id.browserFragment)
     }
 
     @VisibleForTesting

app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt

@@ -442,7 +442,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -470,7 +470,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -514,7 +514,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -563,7 +563,7 @@ class DefaultSessionControlControllerTest {
             )
         }
         verify { controller.submitTopSitesImpressionPing(topSite, position) }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -677,7 +677,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -715,7 +715,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -765,7 +765,10 @@ class DefaultSessionControlControllerTest {
         )
         val controller = spyk(createController())
 
-        every { controller.getAvailableSearchEngines() } returns listOf(googleSearchEngine, duckDuckGoSearchEngine)
+        every { controller.getAvailableSearchEngines() } returns listOf(
+            googleSearchEngine,
+            duckDuckGoSearchEngine,
+        )
 
         try {
             mockkStatic("mozilla.components.browser.state.state.SearchStateKt")
@@ -815,7 +818,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -853,7 +856,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -891,7 +894,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -929,7 +932,7 @@ class DefaultSessionControlControllerTest {
                 startLoading = true,
             )
         }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test
@@ -966,7 +969,7 @@ class DefaultSessionControlControllerTest {
             )
         }
         verify { controller.submitTopSitesImpressionPing(topSite, position) }
-        verify { activity.openToBrowser(BrowserDirection.FromHome) }
+        verify { navController.navigate(R.id.browserFragment) }
     }
 
     @Test