From 1bc79adfab8481b87b57bb7fa11971637e3f3bd5 Mon Sep 17 00:00:00 2001 From: "oana.horvath" Date: Mon, 26 Feb 2024 12:54:14 +0200 Subject: [PATCH 1/2] Bug 1882035 - Disable non-sponsored suggestions UI tests in FirefoxSuggestTest (cherry picked from commit e7ec19745b69e4ed606e6c4590f3d8eb7a1c37ce) --- .../java/org/mozilla/fenix/ui/FirefoxSuggestTest.kt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/FirefoxSuggestTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/FirefoxSuggestTest.kt index a6b6eb35d..b019b8c39 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/FirefoxSuggestTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/FirefoxSuggestTest.kt @@ -192,6 +192,7 @@ class FirefoxSuggestTest { } // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/2348374 + @Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1882035") @SmokeTest @Test fun verifyFirefoxSuggestNonSponsoredSearchResultsTest() { @@ -218,6 +219,7 @@ class FirefoxSuggestTest { } // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/2348375 + @Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1882035") @Test fun verifyFirefoxSuggestNonSponsoredSearchResultsWithPartialKeywordTest() { runWithCondition(TestHelper.appContext.settings().enableFxSuggest) { @@ -237,6 +239,7 @@ class FirefoxSuggestTest { } // TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/2348376 + @Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1882035") @Test fun openFirefoxSuggestNonSponsoredSearchResultsTest() { runWithCondition(TestHelper.appContext.settings().enableFxSuggest) { From 4b28245cbf55fbaff31cb1a1a5ef72bf442b6438 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 29 Feb 2024 14:38:28 +0100 Subject: [PATCH 2/2] Bug 1880150 - Do not wait for attribution before dismissing splash screen (backport #5587) (#5695) (cherry picked from commit 179fff2e8a1a0e6c90ea15c490a52fe47de67cd4) Co-authored-by: Roger Yang --- app/src/main/java/org/mozilla/fenix/HomeActivity.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt index 61cab7c75..5d3cb4fc5 100644 --- a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt +++ b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt @@ -483,8 +483,8 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity { var maxDurationReached = false val delay = FxNimbus.features.splashScreen.value().maximumDurationMs.toLong() splashScreen.setKeepOnScreenCondition { - val dataFetched = components.settings.utmParamsKnown && - components.settings.nimbusExperimentsFetched + val dataFetched = components.settings.nimbusExperimentsFetched + val keepOnScreen = !maxDurationReached && !dataFetched if (!keepOnScreen) { SplashScreen.firstLaunchExtended.record(