From 19572d474ae347dc3d4cefcaadd3561952071fc6 Mon Sep 17 00:00:00 2001 From: Emily Kager Date: Tue, 22 Jan 2019 16:12:20 -0800 Subject: [PATCH] Closes #134 - Collapse/show the toolbar based on browser scrolling --- .../org/mozilla/fenix/home/HomeFragment.kt | 2 +- app/src/main/res/layout/fragment_browser.xml | 77 +++++++++---------- app/src/main/res/layout/fragment_home.xml | 5 +- 3 files changed, 38 insertions(+), 46 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index 62909f53a..9f5497e99 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -44,7 +44,7 @@ class HomeFragment : Fragment() { toolbar_wrapper.clipToOutline = false toolbar.setOnClickListener { it -> val extras = FragmentNavigator.Extras.Builder().addSharedElement( - toolbar_wrapper, ViewCompat.getTransitionName(toolbar_wrapper)!! + toolbar, ViewCompat.getTransitionName(toolbar)!! ).build() Navigation.findNavController(it).navigate(R.id.action_homeFragment_to_browserFragment, null, null, extras) } diff --git a/app/src/main/res/layout/fragment_browser.xml b/app/src/main/res/layout/fragment_browser.xml index 2d0e63607..ea37801d3 100644 --- a/app/src/main/res/layout/fragment_browser.xml +++ b/app/src/main/res/layout/fragment_browser.xml @@ -2,52 +2,45 @@ - + + android:layout_width="match_parent" + android:layout_height="match_parent"> - + android:id="@+id/engineView" + android:layout_width="match_parent" + android:layout_height="match_parent" /> - - - + android:padding="4dp" + android:visibility="gone" + mozac:awesomeBarChipBackgroundColor="#444444" + mozac:awesomeBarChipTextColor="#ffffff" + mozac:awesomeBarDescriptionTextColor="#dddddd" + mozac:awesomeBarTitleTextColor="#ffffff" /> - \ No newline at end of file + + + \ No newline at end of file diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml index 9dbf4da38..4e296238f 100644 --- a/app/src/main/res/layout/fragment_home.xml +++ b/app/src/main/res/layout/fragment_home.xml @@ -12,7 +12,6 @@ app:layoutDescription="@xml/home_scene" tools:context=".home.HomeFragment"> - @@ -69,7 +67,8 @@ android:gravity="center_vertical" android:text="@string/search_hint" android:textColor="@color/searchText" - android:textSize="14sp" /> + android:textSize="14sp" + android:transitionName="firstTransitionName" />