diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index c1dc66093..fe7651834 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -477,6 +477,7 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope, ToolbarMenu.Item.NewTab -> Item.NEW_TAB ToolbarMenu.Item.OpenInFenix -> Item.OPEN_IN_FENIX ToolbarMenu.Item.Share -> Item.SHARE + ToolbarMenu.Item.SaveToCollection -> Item.SAVE_TO_COLLECTION } requireComponents.analytics.metrics.track(Event.BrowserMenuItemTapped(item)) @@ -527,6 +528,10 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope, Navigation.findNavController(view!!).navigate(directions) (activity as HomeActivity).browsingModeManager.mode = BrowsingModeManager.Mode.Normal } + ToolbarMenu.Item.SaveToCollection -> { + ItsNotBrokenSnack(requireContext()) + .showSnackbar("1843") + } ToolbarMenu.Item.OpenInFenix -> { val intent = Intent(context, IntentReceiverActivity::class.java) intent.action = Intent.ACTION_VIEW diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt index ffcacc46e..d0aeef43d 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt @@ -195,7 +195,8 @@ sealed class Event { data class BrowserMenuItemTapped(val item: Item) : Event() { enum class Item { SETTINGS, LIBRARY, HELP, DESKTOP_VIEW_ON, DESKTOP_VIEW_OFF, FIND_IN_PAGE, NEW_TAB, - NEW_PRIVATE_TAB, SHARE, REPORT_SITE_ISSUE, BACK, FORWARD, RELOAD, STOP, OPEN_IN_FENIX + NEW_PRIVATE_TAB, SHARE, REPORT_SITE_ISSUE, BACK, FORWARD, RELOAD, STOP, OPEN_IN_FENIX, + SAVE_TO_COLLECTION } override val extras: Map? diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt index 858772feb..17faa9aa6 100644 --- a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt @@ -164,6 +164,14 @@ class DefaultToolbarMenu( onItemTapped.invoke(ToolbarMenu.Item.ReportIssue) }, + BrowserMenuImageText( + context.getString(R.string.browser_menu_save_to_collection), + R.drawable.ic_archive, + DefaultThemeManager.resolveAttribute(R.attr.primaryText, context) + ) { + onItemTapped.invoke(ToolbarMenu.Item.SaveToCollection) + }, + BrowserMenuDivider(), menuToolbar diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarMenu.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarMenu.kt index eebbe7286..2a8b742be 100644 --- a/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarMenu.kt @@ -19,6 +19,7 @@ interface ToolbarMenu { object Stop : Item() object ReportIssue : Item() object OpenInFenix : Item() + object SaveToCollection : Item() } val menuBuilder: BrowserMenuBuilder diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index c9b23e24d..99b7740bc 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -54,6 +54,8 @@ Private tab New tab + + Save to Collection Report site issue