From 012cc215214f1e43a1e2b0132cfa3dcf22c66318 Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Wed, 17 Feb 2021 19:34:10 -0800 Subject: [PATCH] For #17972: add client id to startup-timeline ping, update docs. This addresses the root problem we're experiencing for this issue - data not showing up in GLAM. --- app/pings.yaml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/app/pings.yaml b/app/pings.yaml index 771cde2b7..1a8502827 100644 --- a/app/pings.yaml +++ b/app/pings.yaml @@ -35,14 +35,18 @@ startup-timeline: description: | This ping is intended to provide an understanding of startup performance. - The ping is intended to be captured by performance testing automation to - report results there, in addition to user telemetry. We place these metrics - into their own ping in order to isolate them and make this process easier. - include_client_id: false + In addition to being captured on real devices, the ping data was prematurely + optimized into this separate ping to be isolated from other metrics to be + more easily captured by performance testing automation but that hasn't + happened in practice. We would have removed it but implementation + details don't make that possible: + https://github.com/mozilla-mobile/fenix/issues/17972#issuecomment-781002987 + include_client_id: true bugs: - https://github.com/mozilla-mobile/fenix/issues/8803 + - https://github.com/mozilla-mobile/fenix/issues/17972 data_reviews: - https://github.com/mozilla-mobile/fenix/pull/9788#pullrequestreview-394228626 notification_emails: - perf-android-fe@mozilla.com - - esmyth@mozilla.com + - mcomella@mozilla.com